Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot download tracked memory leaks #105

Closed
Thioby opened this issue Jul 27, 2023 · 3 comments
Closed

Cannot download tracked memory leaks #105

Thioby opened this issue Jul 27, 2023 · 3 comments
Labels
subtask The issue is subtask of another bigger issue.

Comments

@Thioby
Copy link

Thioby commented Jul 27, 2023

On version 8.0.3 you are not able to download tracked memory leaks.
Screenshot 2023-07-27 at 10 06 05

The problem is here: (_protocol.dart)

Screenshot 2023-07-27 at 10 06 37

As you can see there is 7 types of envelopes, but type that is looked for is Future<Leaks> . Envelope is not found, null from map and then is forced to be not a null, that's why is crashing.

Class class ResponseFromApp<T extends Object> allows passing any object as message. So in case of leaks, as a message is passed Future instead of Leaks itself.

Solution:

In file _registration.dart at line 50 add await before creating ResponseFromApp object


      if (request is RequestForLeakDetails) {
        return ResponseFromApp(await theLeakProvider.collectLeaks())
            .toServiceResponse();
      }
@polina-c
Copy link
Contributor

polina-c commented Aug 6, 2023

Thank you for reporting. This should be addressed.

@polina-c polina-c added the subtask The issue is subtask of another bigger issue. label Aug 14, 2023
@polina-c
Copy link
Contributor

Subtask of flutter/devtools#3951

@polina-c
Copy link
Contributor

polina-c commented Nov 2, 2023

Closing as duplicate of #172

@polina-c polina-c closed this as completed Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
subtask The issue is subtask of another bigger issue.
Projects
None yet
Development

No branches or pull requests

2 participants