Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint to flag duplicated lint rules #1588

Open
pq opened this issue May 29, 2019 · 0 comments
Open

lint to flag duplicated lint rules #1588

pq opened this issue May 29, 2019 · 0 comments
Labels
lint-request P3 A lower priority bug or feature request type-enhancement A request for a change that isn't a bug

Comments

@pq
Copy link
Member

pq commented May 29, 2019

TL;DR: add lints to lint rules in analysis options that duplicate included rules (e.g., pedantic).

More context in googlearchive/pedantic#23, where @kentcb wrote:

Here's my situation: I want to use pedantic but I've also got quite a few extra lints that I want enabled. Some of those will almost certainly be included in pedantic itself at some point. Since the point of pedantic is to adhere to Google's standard, the lints I add are useful as a point of difference. However, nothing guarantees that they are a point of difference.

What's the guidance in this situation? It would be nice to know that if my lint configuration becomes redundant at some point (due to a newer pedantic release) that I would be notified, but it seems that this is not the case (I just tried adding a lint that pedantic has already enabled). Is my only recourse to manually pick through the lints I have enabled and see whether they're redundant? Seems finicky.

Ideally, I'd like the problems to be surfaced in the same manner as other lints. For me, that means the PROBLEMS panel in VS Code.

Presubmits are a nice idea, but aren't portable. It's not uncommon for team members to use different operating systems and - in my experience at least - this makes the use of hooks untenable.

@pq pq added type-enhancement A request for a change that isn't a bug lint-request labels May 29, 2019
@srawlins srawlins added the P3 A lower priority bug or feature request label Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lint-request P3 A lower priority bug or feature request type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

2 participants