Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for filtered logging using onRecord() #21

Closed
DartBot opened this issue Jun 5, 2015 · 4 comments
Closed

Allow for filtered logging using onRecord() #21

DartBot opened this issue Jun 5, 2015 · 4 comments
Labels
type-enhancement A request for a change that isn't a bug

Comments

@DartBot
Copy link

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/853468?v=3" align="left" width="96" height="96"hspace="10"> Issue by stevenroose
Originally opened as dart-lang/sdk#21454

Attachment:
logging-filtering.diff (4.97 KB)
@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/853468?v=3" align="left" width="48" height="48"hspace="10"> Comment by stevenroose

Attachment:
logging-filteredstream.diff (4.86 KB)

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/5449880?v=3" align="left" width="48" height="48"hspace="10"> Comment by iposva-google

Added Pkg-Logging, Area-Pkg, Triaged labels.

@DartBot DartBot added the type-enhancement A request for a change that isn't a bug label Jun 5, 2015
@DartBot DartBot mentioned this issue Jun 5, 2015
Closed
@pq pq added type-enhancement A request for a change that isn't a bug and removed type-enhancement A request for a change that isn't a bug labels Oct 27, 2018
@jamesderlin
Copy link
Contributor

jamesderlin commented Jan 22, 2020 •
edited

Is this still relevant? Does Logger.level not provide sufficient filtering?

@natebosch
Copy link
Member

We definitely prefer not to make onRecord a method. Authors are welcome to use .where on the returned Stream if seeing the level on the logger is not sufficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pq @natebosch @DartBot @jamesderlin