Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can not recognize del tag without space #300

Closed
asjqkkkk opened this issue Aug 8, 2020 · 3 comments · Fixed by #313
Closed

can not recognize del tag without space #300

asjqkkkk opened this issue Aug 8, 2020 · 3 comments · Fixed by #313
Labels
P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@asjqkkkk
Copy link

asjqkkkk commented Aug 8, 2020

markdown source

pas~~t~~

parse code

    final content = 'pas~~t~~';
    final m.Document document = m.Document(
        extensionSet: m.ExtensionSet.gitHubFlavored,
        encodeHtml: false);
    final List<String> lines = content.split(RegExp(r'\r?\n'));
    final nodes = document.parseLines(lines);

and I can not get the del tag, I log it :

Tag:p   attr:{}
  Text:pas~~t~~

image

If I add space before ~~ , it will be:

Tag:p   attr:{}
  Text:pas 
  Tag:del   attr:{}
    Text:t

image

@srawlins
Copy link
Member

srawlins commented Aug 8, 2020

Interesting. The GitHub-Flavored Markdown is not as well-specified as vanilla CommonMark, but it does look like GFM parses pas~~t~~ as struck-through text.

@srawlins srawlins added P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) labels Aug 8, 2020
@asjqkkkk
Copy link
Author

Hi, this issue seems still exist in v2.1.8

@srawlins
Copy link
Member

Yes, it does. It will be fixed in 3.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants