Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When Image src encoded, it changes the valid url to mismatched one #597

Closed
mym0404 opened this issue Mar 18, 2024 · 2 comments · Fixed by #598
Closed

When Image src encoded, it changes the valid url to mismatched one #597

mym0404 opened this issue Mar 18, 2024 · 2 comments · Fixed by #598

Comments

@mym0404
Copy link
Contributor

mym0404 commented Mar 18, 2024

The image url is encoded since #589

Valid Image Url

https://firebasestorage.googleapis.com/v0/b/jagyeok-001.appspot.com/o/exam001%2Fexam001_687_2a0829c9-0349-425e-8615-a309d9d6fbca%7D.png?alt=media&token=17242a6e-ba12-47a6-a567-2f7b88c34229

Transformed Image Url

https://firebasestorage.googleapis.com/v0/b/jagyeok-001.appspot.com/o/exam001/exam001_687_2a0829c9-0349-425e-8615-a309d9d6fbca%7D.png?alt=media&token=17242a6e-ba12-47a6-a567-2f7b88c34229

%2F is converted to /. It is a misbehavior.

This should be correctly shown in commonmark spec.

image

@srawlins
Copy link
Member

Oh ouch! Good catch

@manafire
Copy link

manafire commented May 2, 2024

Oh boy. Well, this certainly explains why most of my Cloud Storage images are broken in my app! Anyone using subfolders would be affected.

I'm getting this behaviour in v7.2.2 from flutter_markdown which depends on markdown: ^7.1.1. Any chance of this fix making it into a 7.2.3 release soon??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants