Flip mockito.dart with mockito_no_mirrors.dart

[matanlurey]

I think it would be worth it just to have package:mockito/mockito.dart not include mirrors.

The only extra function Mockito provides for mirrors users is spy:

dynamic spy(dynamic mock, dynamic spiedObject) {
  var mirror = reflect(spiedObject);
  setDefaultResponse(
      mock,
      () => new CannedResponse(null,
          (Invocation realInvocation) => mirror.delegate(realInvocation)));
  return mock;
}

I am not even sure there is usage of this and could be convinced to just remove it.

/cc @srawlins @TedSander

[srawlins]

I like the idea of 2-stepping it.

• 1.2.0: flip mockito{,_no_mirrors}.dart
• 1.3.0: remove mirrors if we don't need it.

[matanlurey]

+1 to 2-step. Just wanted the buy-in (I'll wait for Ted before starting)

[TedSander]

Spy is actually used but not much just a couple of instances from the code I can see.

I think it isn't that much of a burden to keep it for now. I do agree we should flip the default.

[srawlins]

No flipping the default?

[matanlurey]

Closed on accident.

[matanlurey]

So this already was flipped in 2.0.0-dev - this needs to be merged internally.

[matanlurey]

I believe @srawlins is merging internally.

[srawlins]

@matanlurey made the flip in 2.0.0-dev dc8ce18.