Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[infra] NDK install fails on MacOS GitHub runner #1115

Closed
dcharkes opened this issue May 1, 2024 · 5 comments
Closed

[infra] NDK install fails on MacOS GitHub runner #1115

dcharkes opened this issue May 1, 2024 · 5 comments
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures type-infra A repository infrastructure change or enhancement

Comments

@dcharkes
Copy link
Collaborator

dcharkes commented May 1, 2024

Run nttld/setup-ndk@6a7e9c5494a25c4842ca1011f710300132eacd94
  with:
    ndk-version: r[2](https://github.com/dart-lang/native/actions/runs/8906568850/job/24458937965?pr=1114#step:4:2)6b
    add-to-path: true
    link-to-sdk: false
    local-cache: false
  env:
    DART_HOME: /Users/runner/hostedtoolcache/dart/[3](https://github.com/dart-lang/native/actions/runs/8906568850/job/24458937965?pr=1114#step:4:3).3.4/arm64
    PUB_CACHE: /Users/runner/.pub-cache
Error: Error: Unsupported arch "arm6[4](https://github.com/dart-lang/native/actions/runs/8906568850/job/24458937965?pr=1114#step:4:4)"

I believe the MacOS bots were x64 before. It looks like they silently switched to arm64.

We run the arm64 MacOS bot less often because it wasn't free:

We should check if its free now.

Also, we probably want to keep running things on x64 MacOS.

@dcharkes dcharkes added P1 A high priority bug; for example, a single project is unusable or has many test failures type-infra A repository infrastructure change or enhancement labels May 1, 2024
@dcharkes
Copy link
Collaborator Author

dcharkes commented May 1, 2024

Yep, the default is arm64 now: actions/runner-images#9741

@dcharkes
Copy link
Collaborator Author

dcharkes commented May 1, 2024

Tracking issue for the GitHub action we're using to install the NDK:

However, an NDK should already be pre-installed on the bot:

@dcharkes
Copy link
Collaborator Author

dcharkes commented May 1, 2024

Hello! As stated in the table the only intel-based macOS-14 runner is macos-14-large (doc). There are no plans to introduce macOS-14 intel standard runners as of now.

actions/runner-images#9741 (comment)

@liamappelbe Maybe we should then change the weekly builder to be an x64 one? macos-14-large

@MulverineX
Copy link

It's fixed nttld/setup-ndk#549

@dcharkes
Copy link
Collaborator Author

dcharkes commented May 8, 2024

The GitHub bot already has an NDK pre-installed, so we're using that one now.

https://github.com/dart-lang/native/pull/1114/files#diff-67b78d3322afa689c9b62e854680e8087184f61dd7787f43ceb53f471eef6704

We can get back to installing one manually if we want a specific version of the SDK in the future.

@dcharkes dcharkes closed this as completed May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures type-infra A repository infrastructure change or enhancement
Projects
None yet
Development

No branches or pull requests

2 participants