Default deleteOriginal to true

[HosseinYousefi]

I wonder if deleteOrignal should default to true. If you're casting it's likely that you're only using the new casted value afterwards.

Originally posted by @dcharkes in dart-archive/jnigen#136 (comment)

[dcharkes]

Cross linking issues:

• naming: delete vs release #707

[HosseinYousefi]

I think deleteOriginal should remain false by default.

Rationale:

1. It's really weird for a new user to face something like when there is no explicit release happening.

JString s = ...;
final a = '${s.toDartString()}A';
// so far so good! but later they add:
final b = '${s.toDartString()}B'; // Error! Use after free...

2. Users don't have to delete the original object, it's only going to be slightly less efficient since we're creating a new global reference.

However deleteOriginal or even releaseOriginal is a bit verbose, so maybe we can come up with a shorter name like convert: true (Not exactly this one).

[HosseinYousefi]

Alternatively, we could add two methods for each kind:

• toDartString(), castTo, ... would keep the original:
• asDartString(), castAs, ... would release it

Maybe to and as are confusing though...

[HosseinYousefi]

Closing as deleteOriginal or releaseOriginal after the rename will stay false by default.