Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

☂️ Refactor JObject hierarchy #981

Closed
4 tasks done
HosseinYousefi opened this issue Mar 6, 2024 · 0 comments · Fixed by #1060
Closed
4 tasks done

☂️ Refactor JObject hierarchy #981

HosseinYousefi opened this issue Mar 6, 2024 · 0 comments · Fixed by #1060

Comments

@HosseinYousefi
Copy link
Member

HosseinYousefi commented Mar 6, 2024

In preparation for dart-lang/sdk#55062, we need to change the structure of JObject to be composed of a JReference instead of inheriting one. This makes it more natural, where a JObject is a JReference and a JType and the JReference itself is responsible for its life cycle and not the JObject (See #970 (comment)).

This potentially enables us to have multiple kinds of JReferences like JGlobalReference and JWeakGlobalReference or a global reference that is not managed by a native finalizer.

For version 0.8.0, we can land these changes all at once:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant