Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Self-execute closures for assert() #46

Merged
merged 1 commit into from
Jan 9, 2018
Merged

Self-execute closures for assert() #46

merged 1 commit into from
Jan 9, 2018

Conversation

srawlins
Copy link
Contributor

@srawlins srawlins commented Jan 8, 2018

The dart language will soon stop accepting closures into assert: dart-lang/sdk#30326

This PR changes the asserts in observable to self-execute it's closures, so that a mere bool is passed to assert().

@srawlins srawlins merged commit 8a225cb into google:master Jan 9, 2018
@srawlins srawlins deleted the bool-asserts branch January 9, 2018 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matanlurey matanlurey matanlurey approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@srawlins @matanlurey @googlebot