Skip to content
This repository has been archived by the owner on Sep 15, 2021. It is now read-only.

Fix material-tab height in angular_components sample #27

Closed
kwalrath opened this issue Jan 4, 2017 · 4 comments
Closed

Fix material-tab height in angular_components sample #27

kwalrath opened this issue Jan 4, 2017 · 4 comments

Comments

@kwalrath
Copy link
Contributor

kwalrath commented Jan 4, 2017

The UI in https://github.com/dart-lang/one-hour-codelab/tree/master/angular2_components/4-final currently bounces around. (You can see it running here. Click the tabs. If you don't see the problem, make your window smaller.)

angulardart/angular_components#12 says how to fix this bug.

@kwalrath kwalrath self-assigned this Jan 4, 2017
@nshahan
Copy link

nshahan commented Jan 4, 2017

I am actually wondering if this what you are describing is a different issue. I am observing that when the window doesn't have enough vertical space to fully display the tab, switching between tabs will automatically scroll the window to the top of tab contents. Is that what you are seeing?

@kwalrath
Copy link
Contributor Author

kwalrath commented Jan 4, 2017

Yes, that's what I'm seeing. It feels wrong because I want the tabs to stay in the same place, so I can easily switch between them. I haven't tried the fix... I just assumed that my problem was everyone's problem.

@nshahan
Copy link

nshahan commented Jan 5, 2017

To me is seems more like the tabs are staying in the same place but the window is scroll position is getting automatically changed. Either way, you are right, it doesn't feel good.

@kwalrath kwalrath removed their assignment Jul 19, 2017
@chalin chalin changed the title Fix material-tab height in angular2_components sample Fix material-tab height in angular_components sample Sep 14, 2017
@chalin
Copy link
Contributor

chalin commented Sep 14, 2017

This issue was moved to dart-lang/site-webdev#1047

@chalin chalin closed this as completed Sep 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

3 participants