Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pana should use --suppress-analytics instead of --no-analytics #1208

Closed
sigurdm opened this issue Mar 28, 2023 · 2 comments · Fixed by #1212
Closed

Pana should use --suppress-analytics instead of --no-analytics #1208

sigurdm opened this issue Mar 28, 2023 · 2 comments · Fixed by #1212

Comments

@sigurdm
Copy link
Contributor

sigurdm commented Mar 28, 2023

The old argument was deprecated
See dart-lang/linter#4204 .

I don't know if we need to branch depending on the version of the analysing sdk?

@isoos what do you think?
@isoos
Copy link
Collaborator

isoos commented Mar 28, 2023 •
edited
Loading

I don't know if we need to branch depending on the version of the analysing sdk?

Update: I don't think we need a git branch, but we need a different logic in pana to handle different SDKs.

@sigurdm
Copy link
Contributor Author

sigurdm commented Mar 30, 2023

Yeah - not git branch - conditional branching :)

@isoos isoos mentioned this issue Apr 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed --[no|suppress]-analytics flags and using CI=true instead. isoos/pana
2 participants
@isoos @sigurdm