Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serve /documentation URLs through default service (frontend). #1551

Merged
merged 2 commits into from Aug 24, 2018

Conversation

isoos
Copy link
Collaborator

@isoos isoos commented Aug 23, 2018

Part of #1534

  • tests and the redirect logic is copied almost verbatim
  • the serving handler is referenced
  • tweak added to preserve the original request after sanitization, and work on that if it is in the context

Copy link

@sortie sortie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Though I am not quite certain how this stops redirecting to the dartdoc instance and serves itself instead.

@isoos
Copy link
Collaborator Author

isoos commented Aug 24, 2018

Though I am not quite certain how this stops redirecting to the dartdoc instance and serves itself instead.

Oh, true, that's the dispatch.yaml. I'm not yet sure if we should remove it (but then how to deploy it), make it empty, or override the dartdoc references to default there.

@isoos
Copy link
Collaborator Author

isoos commented Aug 24, 2018

Copy link

@sortie sortie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@isoos isoos merged commit 604b206 into dart-lang:master Aug 24, 2018
@isoos isoos deleted the frontend_dartdoc branch August 24, 2018 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants