Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit pkg/pub_dartdoc initialization #2004

Merged
merged 3 commits into from Feb 4, 2019

Conversation

isoos
Copy link
Collaborator

@isoos isoos commented Feb 1, 2019

No description provided.

### Update/upgrade dependencies

````bash
pub global run mono_repo --recursive pub get
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be ?

pub global run mono_repo --recursive pub upgrade

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could display both: get for a freshly cloned repository, upgrade for a dependency upgrade.

The reason I'd rather default to get is pkg/pub_dartdoc: it is on a separate dependency tree than the rest of the packages, and while there is very little risk of screwing it up with a upgrade, I'd rather not suggest it in the doc.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem then.

Copy link
Contributor

@sigurdm sigurdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isoos isoos merged commit ecfbcd6 into dart-lang:master Feb 4, 2019
@isoos isoos deleted the dockerfile_update branch February 4, 2019 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants