Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precompiled executables should fail gracefully if a dependency fails to load #1114

Closed
DartBot opened this issue Jun 5, 2015 · 4 comments
Closed
Labels
type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@DartBot
Copy link

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/188?v=3" align="left" width="96" height="96"hspace="10"> Issue by nex3
Originally opened as dart-lang/sdk#20748


From running "pub get" on pop pop win:

Resolving dependencies...

  • barback 0.15.0+1
  • bot 0.27.0+2
  • browser 0.10.0+2
  • chrome 0.5.6 (0.6.1 available)
  • collection 1.0.0
  • matcher 0.11.1
  • path 1.3.0
  • pool 1.0.1
  • source_span 1.0.0
  • stack_trace 1.0.2
  • stagexl 0.9.4+2
  • unittest 0.11.0+5
    Changed 12 dependencies!
    Precompiling executables...
    Loading source assets...
    Failed to precompile chrome:setup_app:
    Unhandled exception:
    Uncaught Error: Failure getting http://localhost:56686/packages/unscripted/unscripted.dart: 404 Not Found
    Stack Trace:
    #­0 _asyncLoadError (dart:_builtin:339)
    #­1 _httpGet.<anonymous closure>.<anonymous closure> (dart:_builtin:128)
    #­2 _RootZone.runGuarded (dart:async/zone.dart:1009)
    #­3 _BufferingStreamSubscription._sendDone.sendDone (dart:async/stream_impl.dart:390)
    #­4 _BufferingStreamSubscription._sendDone (dart:async/stream_impl.dart:399)
    #­5 _BufferingStreamSubscription._close (dart:async/stream_impl.dart:290)
    #­6 _ForwardingStream._handleDone (dart:async/stream_pipe.dart:94)
    #­7 _handleDone (dart:async/stream_pipe.dart:162)
    #­8 _RootZone.runGuarded (dart:async/zone.dart:1009)
    #­9 _BufferingStreamSubscription._sendDone.sendDone (dart:async/stream_impl.dart:390)
    #­10 _BufferingStreamSubscription._sendDone (dart:async/stream_impl.dart:399)
    #­11 _DelayedDone.perform (dart:async/stream_impl.dart:614)
    #­12 _StreamImplEvents.handleNext (dart:async/stream_impl.dart:711)
    #­13 _PendingEvents.schedule.<anonymous closure> (dart:async/stream_impl.dart:671)
    #­14 _asyncRunCallbackLoop (dart:async/schedule_microtask.dart:41)
    #­15 _asyncRunCallback (dart:async/schedule_microtask.dart:48)
    #­16 _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:84)
    #­17 _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:131)

­0 _rootHandleUncaughtError.<anonymous closure> (dart:async/zone.dart:820)

­1 _asyncRunCallbackLoop (dart:async/schedule_microtask.dart:41)

­2 _asyncRunCallback (dart:async/schedule_microtask.dart:48)

­3 _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:84)

­4 _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:131)

Unfortunately due to issue dart-lang/sdk#1 there's not a great way to handle these exceptions, but we can do some manual string parsing and convert them to something a little nicer.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/188?v=3" align="left" width="48" height="48"hspace="10"> Comment by nex3


Issue #1115 has been merged into this issue.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/405837?v=3" align="left" width="48" height="48"hspace="10"> Comment by zoechi


Issue #1115 has been merged into this issue.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/188?v=3" align="left" width="48" height="48"hspace="10"> Comment by nex3


Issue #1175 has been merged into this issue.

@nex3
Copy link
Member

nex3 commented Dec 9, 2015

This error has since been improved.

@nex3 nex3 closed this as completed Dec 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

2 participants