Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pub install: could the no-op case be faster? #843

Closed
DartBot opened this issue Jun 5, 2015 · 1 comment
Closed

pub install: could the no-op case be faster? #843

DartBot opened this issue Jun 5, 2015 · 1 comment
Labels
closed-duplicate Closed in favor of an existing report type-enhancement A request for a change that isn't a bug

Comments

@DartBot
Copy link

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/17034?v=3" align="left" width="96" height="96"hspace="10"> Issue by kevmoo
Originally opened as dart-lang/sdk#16494


~> time pub install
Resolving dependencies...
Got dependencies!

real 0m0.620s
user 0m0.557s
sys 0m0.060s

I could imagine this being useful in more places...or run often/always from other tools (hop) to make sure everything is up-to-date.

BUT! half a second is likely a bit too much overhead.

Is there room here to optimize? Just curious...

Flagging as enhancement, because I think for the common case now, it's plenty fast.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="48" height="48"hspace="10"> Comment by munificent


The majority of that time is probably removing and recreating the "packages" directory with the symlinks in it. I'm just going to close this out as a dupe of that and hopefully it will get faster when we can get rid of symlinks.


Added Duplicate label.
Marked as being merged into #727.

@DartBot DartBot added closed-duplicate Closed in favor of an existing report type-enhancement A request for a change that isn't a bug labels Jun 5, 2015
@DartBot DartBot closed this as completed Jun 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-duplicate Closed in favor of an existing report type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

1 participant