Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.3] Update "Getters can’t be promoted" for status in Dart 3.3 #5441

Closed
parlough opened this issue Dec 29, 2023 · 1 comment
Closed

[3.3] Update "Getters can’t be promoted" for status in Dart 3.3 #5441

parlough opened this issue Dec 29, 2023 · 1 comment
Assignees
Labels
a.language Relates to the Dart language tour dev.type-promotion Relates to type promotion concepts and examples dev.type-system Relates to the type system in Dart e1-hours Can complete in < 8 hours of normal, not dedicated, work p1-high Major but not urgent concern: Resolve in months. Update each month. st.triage.ltw Indicates Lead Tech Writer has triaged

Comments

@parlough
Copy link
Member

parlough commented Dec 29, 2023

Section to update: https://dart.dev/tools/non-promotion-reasons#not-field

The discussion and following note will need to be updated to account for the expansion of type promotion to some abstract getters (dart-lang/sdk#54056).

Since the destination will still be linked to by previous releases of Dart, make sure to leave a version note for before 3.3. Another option is to introduce a new section and link for 3.3 and maintain the existing section for earlier versions.

@parlough parlough added a.language Relates to the Dart language tour p2-medium Necessary but not urgent concern. Resolve when possible. e1-hours Can complete in < 8 hours of normal, not dedicated, work dev.type-system Relates to the type system in Dart dev.type-promotion Relates to type promotion concepts and examples labels Dec 29, 2023
@atsansone atsansone added the st.triage.ltw Indicates Lead Tech Writer has triaged label Feb 13, 2024
@parlough parlough added p1-high Major but not urgent concern: Resolve in months. Update each month. and removed p2-medium Necessary but not urgent concern. Resolve when possible. labels Feb 15, 2024
@parlough
Copy link
Member Author

Fixed by 59b4d26. Thanks Marya!

The commit didn't add a mention of which version this changed in, but I think it's probably fine in this case as the note is an exception to the above primary documentation. If anyone raises it as a point of confusion or feels strongly, we can adjust it further :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a.language Relates to the Dart language tour dev.type-promotion Relates to type promotion concepts and examples dev.type-system Relates to the type system in Dart e1-hours Can complete in < 8 hours of normal, not dedicated, work p1-high Major but not urgent concern: Resolve in months. Update each month. st.triage.ltw Indicates Lead Tech Writer has triaged
Projects
None yet
Development

No branches or pull requests

3 participants