Skip to content
This repository has been archived by the owner on May 31, 2021. It is now read-only.

Update minSDK and dependencies #614

Merged
merged 6 commits into from Jul 2, 2019
Merged

Update minSDK and dependencies #614

merged 6 commits into from Jul 2, 2019

Conversation

domesticmouse
Copy link
Contributor

No description provided.

@domesticmouse
Copy link
Contributor Author

PTAL @kevmoo

@kevmoo
Copy link
Contributor

kevmoo commented Jun 20, 2019

What does this get us?

@domesticmouse
Copy link
Contributor Author

Impetus for this sweep was dart-archive/dart-tutorials-samples#49 (comment)

@domesticmouse
Copy link
Contributor Author

Travis breakage is due to dart-lang/sdk#37324

@domesticmouse
Copy link
Contributor Author

@kevmoo I thought more about your question about what this gets us and I have a different answer now that I'm not knee deep in changes.

Modifying the default getting started experience for Stagehand users to include the latest version of the language means that if they are trying out things like UI as Code, they don't get confusing lint warnings and start wondering if everything is broken.

I'm curious what you see as the upside to keeping minSDK at a lower bound? This is going to be a very real problem once we want the community to start getting the upside of NNBD.

@kevmoo
Copy link
Contributor

kevmoo commented Jun 21, 2019

Language features is a good reason. Just checking that we have one. 😄

@domesticmouse
Copy link
Contributor Author

@kevmoo can you poke Travis? It should rebuild clean now that dart_internal has been updated.

CHANGELOG.md Outdated
@@ -1,3 +1,7 @@
## 3.3.2
- Updated minimum Dart SDK to 2.3
- Updated dependency versions across all templates
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very Important Comment: We add a period after each list item.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor

@kwalrath kwalrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update to 2.4? :/

@domesticmouse
Copy link
Contributor Author

And updated most of the templates to 2.4.

@domesticmouse
Copy link
Contributor Author

PTAL @kwalrath

Copy link
Contributor

@kwalrath kwalrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks, @domesticmouse!

@kwalrath kwalrath merged commit 734f1e8 into dart-archive:master Jul 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants