Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up the isJS and isWasm booleans from the Runtime wire format #2146

Open
jakemac53 opened this issue Dec 1, 2023 · 1 comment
Open

Clean up the isJS and isWasm booleans from the Runtime wire format #2146

jakemac53 opened this issue Dec 1, 2023 · 1 comment
Labels
status-blocked Blocked from making progress by another (referenced) issue type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable

Comments

@jakemac53
Copy link
Contributor

I am faking them for now when serializing, to maintain backwards compatibility with older flutter versions, when a user doesn't have a (transitive) dependency on test_api. But we should delete them after some period of time (TBD).
@jakemac53 jakemac53 added type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable status-blocked Blocked from making progress by another (referenced) issue labels Dec 1, 2023
@jakemac53
Copy link
Contributor Author

jakemac53 commented Dec 1, 2023 •
edited
Loading

Blocked on flutter/flutter#91107 specifically although we should maintain this backward compatibility for at least one stable version of flutter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status-blocked Blocked from making progress by another (referenced) issue type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jakemac53