Fix path to launch firefox on macOS #2195
Open
+106
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakemac53
reviewed
Mar 4, 2024
|
Ah crap, I realize now that this doesn't work for the executables which aren't actually a file path, but instead are an executable name expected to be on your PATH. Not sure the best way to deal with those, cc @natebosch ideas? |
|
I don't recall a way to check for an executable on the If macOS is the only one which needs multiple options today, should we only update the mac behavior to support multiple full paths? |
|
We can do a workaround in We are able to do a workaround by setting the following yaml. override_platforms:
firefox:
settings:
executable:
mac_os: '/Applications/Firefox.app/Contents/MacOS/firefox-bin' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix firefox startup path, as
dart test -p firefoxcan no longer be executed on macOS.close #2194
I checked the workflow and both macos and firefox are removed from the execution environment. In relation to PR, do I need to add macos and firefox execution patterns to the workflow?
Contribution guidelines:
dart format.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.