Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EventStreamProviders events are tied to dart:html-specific logic #168

Open
srujzs opened this issue Feb 12, 2024 · 1 comment
Open

EventStreamProviders events are tied to dart:html-specific logic #168

srujzs opened this issue Feb 12, 2024 · 1 comment

Comments

@srujzs
Copy link
Contributor

srujzs commented Feb 12, 2024

We expose a number of EventStreamProviders to make it easier for people to subscribe to various events via Streams: https://github.com/dart-lang/web/blob/main/lib/src/helpers/events/events.dart. However, they're tied to the specifics of the dart:html implementation e.g. using webkit prefixes even though that prefix hasn't been used for many years: https://developer.mozilla.org/en-US/docs/Web/API/Document/fullscreenchange_event. Should we instead have them be reflective of the current web instead of what dart:html exposes? This may make it a tiny bit harder to migrate in some cases, but is likely worth it.

@kevmoo
Copy link
Member

kevmoo commented Feb 12, 2024

We 100% should map to where things are, not where they were!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants