Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@Function, @Field, and @Class responses should include populated location #1428

Open
Tracked by #3447
bkonyi opened this issue Oct 13, 2021 · 2 comments
Open
Tracked by #3447

Comments

@bkonyi
Copy link
Contributor

bkonyi commented Oct 13, 2021

The location property for @Function, @Field, and @Class is technically marked as optional in the specification for legacy reasons, but should always be provided in order to allow for these objects to be associated with a parent script. Having location information also allows for us to determine where the code is in a script without having to request the full object.

This is blocking program explorer from working correctly with dwds.

@annagrin
Copy link
Contributor

annagrin commented Oct 19, 2021

We were planning to provide precise locations via debug symbols metadata, which is still in progress. That will take time though as it requires DDC to provide the symbols, and significant changes in dwds.

@leonsenft you had a similar request and tried to work around it, do I understand correctly that workarounds using source maps are not working as well as expected?

@leonsenft
Copy link
Contributor

Correct, I was unable to find a suitable workaround. I wanted a way to jump to the definition of a class. The best I could do was jump to a constructor, but that was unreliable depending on the number of parameters the constructor had, and sometimes just didn't work at all and would jump into JavaScript.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants