refactor: refactor enum projections (#338)

packages/windows_ai/lib/src/machinelearning/learningmodeldevicekind.dart

@@ -23,7 +23,5 @@ enum LearningModelDeviceKind implements WinRTEnum {
   const LearningModelDeviceKind(this.value);
 
   factory LearningModelDeviceKind.from(int value) =>
-      LearningModelDeviceKind.values.firstWhere((e) => e.value == value,
-          orElse: () => throw ArgumentError.value(
-              value, 'value', 'No enum value with that value'));
+      LearningModelDeviceKind.values.byValue(value);
 }

packages/windows_ai/lib/src/machinelearning/learningmodelfeaturekind.dart

@@ -21,7 +21,5 @@ enum LearningModelFeatureKind implements WinRTEnum {
   const LearningModelFeatureKind(this.value);
 
   factory LearningModelFeatureKind.from(int value) =>
-      LearningModelFeatureKind.values.firstWhere((e) => e.value == value,
-          orElse: () => throw ArgumentError.value(
-              value, 'value', 'No enum value with that value'));
+      LearningModelFeatureKind.values.byValue(value);
 }

packages/windows_ai/lib/src/machinelearning/learningmodelpixelrange.dart

@@ -21,7 +21,5 @@ enum LearningModelPixelRange implements WinRTEnum {
   const LearningModelPixelRange(this.value);
 
   factory LearningModelPixelRange.from(int value) =>
-      LearningModelPixelRange.values.firstWhere((e) => e.value == value,
-          orElse: () => throw ArgumentError.value(
-              value, 'value', 'No enum value with that value'));
+      LearningModelPixelRange.values.byValue(value);
 }

packages/windows_ai/lib/src/machinelearning/tensorkind.dart

@@ -32,8 +32,5 @@ enum TensorKind implements WinRTEnum {
 
   const TensorKind(this.value);
 
-  factory TensorKind.from(int value) =>
-      TensorKind.values.firstWhere((e) => e.value == value,
-          orElse: () => throw ArgumentError.value(
-              value, 'value', 'No enum value with that value'));
+  factory TensorKind.from(int value) => TensorKind.values.byValue(value);
 }

packages/windows_applicationmodel/lib/src/appexecutioncontext.dart

@@ -20,7 +20,5 @@ enum AppExecutionContext implements WinRTEnum {
   const AppExecutionContext(this.value);
 
   factory AppExecutionContext.from(int value) =>
-      AppExecutionContext.values.firstWhere((e) => e.value == value,
-          orElse: () => throw ArgumentError.value(
-              value, 'value', 'No enum value with that value'));
+      AppExecutionContext.values.byValue(value);
 }

packages/windows_applicationmodel/lib/src/appinstallerpolicysource.dart

@@ -19,7 +19,5 @@ enum AppInstallerPolicySource implements WinRTEnum {
   const AppInstallerPolicySource(this.value);
 
   factory AppInstallerPolicySource.from(int value) =>
-      AppInstallerPolicySource.values.firstWhere((e) => e.value == value,
-          orElse: () => throw ArgumentError.value(
-              value, 'value', 'No enum value with that value'));
+      AppInstallerPolicySource.values.byValue(value);
 }

packages/windows_applicationmodel/lib/src/packagecontentgroupstate.dart

@@ -21,7 +21,5 @@ enum PackageContentGroupState implements WinRTEnum {
   const PackageContentGroupState(this.value);
 
   factory PackageContentGroupState.from(int value) =>
-      PackageContentGroupState.values.firstWhere((e) => e.value == value,
-          orElse: () => throw ArgumentError.value(
-              value, 'value', 'No enum value with that value'));
+      PackageContentGroupState.values.byValue(value);
 }

packages/windows_applicationmodel/lib/src/packagerelationship.dart

@@ -20,7 +20,5 @@ enum PackageRelationship implements WinRTEnum {
   const PackageRelationship(this.value);
 
   factory PackageRelationship.from(int value) =>
-      PackageRelationship.values.firstWhere((e) => e.value == value,
-          orElse: () => throw ArgumentError.value(
-              value, 'value', 'No enum value with that value'));
+      PackageRelationship.values.byValue(value);
 }

packages/windows_applicationmodel/lib/src/packagesignaturekind.dart

@@ -23,7 +23,5 @@ enum PackageSignatureKind implements WinRTEnum {
   const PackageSignatureKind(this.value);
 
   factory PackageSignatureKind.from(int value) =>
-      PackageSignatureKind.values.firstWhere((e) => e.value == value,
-          orElse: () => throw ArgumentError.value(
-              value, 'value', 'No enum value with that value'));
+      PackageSignatureKind.values.byValue(value);
 }

packages/windows_applicationmodel/lib/src/packageupdateavailability.dart

@@ -23,7 +23,5 @@ enum PackageUpdateAvailability implements WinRTEnum {
   const PackageUpdateAvailability(this.value);
 
   factory PackageUpdateAvailability.from(int value) =>
-      PackageUpdateAvailability.values.firstWhere((e) => e.value == value,
-          orElse: () => throw ArgumentError.value(
-              value, 'value', 'No enum value with that value'));
+      PackageUpdateAvailability.values.byValue(value);
 }

packages/windows_applicationmodel/lib/src/startuptaskstate.dart

@@ -23,7 +23,5 @@ enum StartupTaskState implements WinRTEnum {
   const StartupTaskState(this.value);
 
   factory StartupTaskState.from(int value) =>
-      StartupTaskState.values.firstWhere((e) => e.value == value,
-          orElse: () => throw ArgumentError.value(
-              value, 'value', 'No enum value with that value'));
+      StartupTaskState.values.byValue(value);
 }

packages/windows_data/lib/src/json/jsonerrorstatus.dart

@@ -22,7 +22,5 @@ enum JsonErrorStatus implements WinRTEnum {
   const JsonErrorStatus(this.value);
 
   factory JsonErrorStatus.from(int value) =>
-      JsonErrorStatus.values.firstWhere((e) => e.value == value,
-          orElse: () => throw ArgumentError.value(
-              value, 'value', 'No enum value with that value'));
+      JsonErrorStatus.values.byValue(value);
 }

packages/windows_data/lib/src/json/jsonvaluetype.dart

@@ -22,8 +22,5 @@ enum JsonValueType implements WinRTEnum {
 
   const JsonValueType(this.value);
 
-  factory JsonValueType.from(int value) =>
-      JsonValueType.values.firstWhere((e) => e.value == value,
-          orElse: () => throw ArgumentError.value(
-              value, 'value', 'No enum value with that value'));
+  factory JsonValueType.from(int value) => JsonValueType.values.byValue(value);
 }

packages/windows_data/lib/src/xml/dom/nodetype.dart

@@ -29,8 +29,5 @@ enum NodeType implements WinRTEnum {
 
   const NodeType(this.value);
 
-  factory NodeType.from(int value) =>
-      NodeType.values.firstWhere((e) => e.value == value,
-          orElse: () => throw ArgumentError.value(
-              value, 'value', 'No enum value with that value'));
+  factory NodeType.from(int value) => NodeType.values.byValue(value);
 }

packages/windows_devices/lib/src/display/displaymonitorconnectionkind.dart

@@ -22,7 +22,5 @@ enum DisplayMonitorConnectionKind implements WinRTEnum {
   const DisplayMonitorConnectionKind(this.value);
 
   factory DisplayMonitorConnectionKind.from(int value) =>
-      DisplayMonitorConnectionKind.values.firstWhere((e) => e.value == value,
-          orElse: () => throw ArgumentError.value(
-              value, 'value', 'No enum value with that value'));
+      DisplayMonitorConnectionKind.values.byValue(value);
 }

packages/windows_devices/lib/src/display/displaymonitordescriptorkind.dart

@@ -20,7 +20,5 @@ enum DisplayMonitorDescriptorKind implements WinRTEnum {
   const DisplayMonitorDescriptorKind(this.value);
 
   factory DisplayMonitorDescriptorKind.from(int value) =>
-      DisplayMonitorDescriptorKind.values.firstWhere((e) => e.value == value,
-          orElse: () => throw ArgumentError.value(
-              value, 'value', 'No enum value with that value'));
+      DisplayMonitorDescriptorKind.values.byValue(value);
 }

packages/windows_devices/lib/src/display/displaymonitorphysicalconnectorkind.dart

@@ -26,8 +26,5 @@ enum DisplayMonitorPhysicalConnectorKind implements WinRTEnum {
   const DisplayMonitorPhysicalConnectorKind(this.value);
 
   factory DisplayMonitorPhysicalConnectorKind.from(int value) =>
-      DisplayMonitorPhysicalConnectorKind.values.firstWhere(
-          (e) => e.value == value,
-          orElse: () => throw ArgumentError.value(
-              value, 'value', 'No enum value with that value'));
+      DisplayMonitorPhysicalConnectorKind.values.byValue(value);
 }

packages/windows_devices/lib/src/display/displaymonitorusagekind.dart

@@ -21,7 +21,5 @@ enum DisplayMonitorUsageKind implements WinRTEnum {
   const DisplayMonitorUsageKind(this.value);
 
   factory DisplayMonitorUsageKind.from(int value) =>
-      DisplayMonitorUsageKind.values.firstWhere((e) => e.value == value,
-          orElse: () => throw ArgumentError.value(
-              value, 'value', 'No enum value with that value'));
+      DisplayMonitorUsageKind.values.byValue(value);
 }

packages/windows_devices/lib/src/enumeration/deviceclass.dart

@@ -23,8 +23,5 @@ enum DeviceClass implements WinRTEnum {
 
   const DeviceClass(this.value);
 
-  factory DeviceClass.from(int value) =>
-      DeviceClass.values.firstWhere((e) => e.value == value,
-          orElse: () => throw ArgumentError.value(
-              value, 'value', 'No enum value with that value'));
+  factory DeviceClass.from(int value) => DeviceClass.values.byValue(value);
 }

packages/windows_devices/lib/src/enumeration/deviceinformationkind.dart

@@ -26,7 +26,5 @@ enum DeviceInformationKind implements WinRTEnum {
   const DeviceInformationKind(this.value);
 
   factory DeviceInformationKind.from(int value) =>
-      DeviceInformationKind.values.firstWhere((e) => e.value == value,
-          orElse: () => throw ArgumentError.value(
-              value, 'value', 'No enum value with that value'));
+      DeviceInformationKind.values.byValue(value);
 }

packages/windows_devices/lib/src/enumeration/devicepairingprotectionlevel.dart

@@ -21,7 +21,5 @@ enum DevicePairingProtectionLevel implements WinRTEnum {
   const DevicePairingProtectionLevel(this.value);
 
   factory DevicePairingProtectionLevel.from(int value) =>
-      DevicePairingProtectionLevel.values.firstWhere((e) => e.value == value,
-          orElse: () => throw ArgumentError.value(
-              value, 'value', 'No enum value with that value'));
+      DevicePairingProtectionLevel.values.byValue(value);
 }

packages/windows_devices/lib/src/enumeration/devicepairingresultstatus.dart

@@ -39,7 +39,5 @@ enum DevicePairingResultStatus implements WinRTEnum {
   const DevicePairingResultStatus(this.value);
 
   factory DevicePairingResultStatus.from(int value) =>
-      DevicePairingResultStatus.values.firstWhere((e) => e.value == value,
-          orElse: () => throw ArgumentError.value(
-              value, 'value', 'No enum value with that value'));
+      DevicePairingResultStatus.values.byValue(value);
 }

packages/windows_devices/lib/src/enumeration/deviceunpairingresultstatus.dart

@@ -22,7 +22,5 @@ enum DeviceUnpairingResultStatus implements WinRTEnum {
   const DeviceUnpairingResultStatus(this.value);
 
   factory DeviceUnpairingResultStatus.from(int value) =>
-      DeviceUnpairingResultStatus.values.firstWhere((e) => e.value == value,
-          orElse: () => throw ArgumentError.value(
-              value, 'value', 'No enum value with that value'));
+      DeviceUnpairingResultStatus.values.byValue(value);
 }

packages/windows_devices/lib/src/enumeration/devicewatchereventkind.dart

@@ -20,7 +20,5 @@ enum DeviceWatcherEventKind implements WinRTEnum {
   const DeviceWatcherEventKind(this.value);
 
   factory DeviceWatcherEventKind.from(int value) =>
-      DeviceWatcherEventKind.values.firstWhere((e) => e.value == value,
-          orElse: () => throw ArgumentError.value(
-              value, 'value', 'No enum value with that value'));
+      DeviceWatcherEventKind.values.byValue(value);
 }

packages/windows_devices/lib/src/enumeration/devicewatcherstatus.dart

@@ -23,7 +23,5 @@ enum DeviceWatcherStatus implements WinRTEnum {
   const DeviceWatcherStatus(this.value);
 
   factory DeviceWatcherStatus.from(int value) =>
-      DeviceWatcherStatus.values.firstWhere((e) => e.value == value,
-          orElse: () => throw ArgumentError.value(
-              value, 'value', 'No enum value with that value'));
+      DeviceWatcherStatus.values.byValue(value);
 }

packages/windows_devices/lib/src/enumeration/panel.dart

@@ -24,8 +24,5 @@ enum Panel implements WinRTEnum {
 
   const Panel(this.value);
 
-  factory Panel.from(int value) =>
-      Panel.values.firstWhere((e) => e.value == value,
-          orElse: () => throw ArgumentError.value(
-              value, 'value', 'No enum value with that value'));
+  factory Panel.from(int value) => Panel.values.byValue(value);
 }

packages/windows_devices/lib/src/geolocation/altitudereferencesystem.dart

@@ -23,7 +23,5 @@ enum AltitudeReferenceSystem implements WinRTEnum {
   const AltitudeReferenceSystem(this.value);
 
   factory AltitudeReferenceSystem.from(int value) =>
-      AltitudeReferenceSystem.values.firstWhere((e) => e.value == value,
-          orElse: () => throw ArgumentError.value(
-              value, 'value', 'No enum value with that value'));
+      AltitudeReferenceSystem.values.byValue(value);
 }

packages/windows_devices/lib/src/geolocation/geolocationaccessstatus.dart

@@ -20,7 +20,5 @@ enum GeolocationAccessStatus implements WinRTEnum {
   const GeolocationAccessStatus(this.value);
 
   factory GeolocationAccessStatus.from(int value) =>
-      GeolocationAccessStatus.values.firstWhere((e) => e.value == value,
-          orElse: () => throw ArgumentError.value(
-              value, 'value', 'No enum value with that value'));
+      GeolocationAccessStatus.values.byValue(value);
 }

packages/windows_devices/lib/src/geolocation/geoshapetype.dart

@@ -20,8 +20,5 @@ enum GeoshapeType implements WinRTEnum {
 
   const GeoshapeType(this.value);
 
-  factory GeoshapeType.from(int value) =>
-      GeoshapeType.values.firstWhere((e) => e.value == value,
-          orElse: () => throw ArgumentError.value(
-              value, 'value', 'No enum value with that value'));
+  factory GeoshapeType.from(int value) => GeoshapeType.values.byValue(value);
 }

packages/windows_devices/lib/src/geolocation/positionaccuracy.dart

@@ -20,7 +20,5 @@ enum PositionAccuracy implements WinRTEnum {
   const PositionAccuracy(this.value);
 
   factory PositionAccuracy.from(int value) =>
-      PositionAccuracy.values.firstWhere((e) => e.value == value,
-          orElse: () => throw ArgumentError.value(
-              value, 'value', 'No enum value with that value'));
+      PositionAccuracy.values.byValue(value);
 }

packages/windows_devices/lib/src/geolocation/positionsource.dart

@@ -24,7 +24,5 @@ enum PositionSource implements WinRTEnum {
   const PositionSource(this.value);
 
   factory PositionSource.from(int value) =>
-      PositionSource.values.firstWhere((e) => e.value == value,
-          orElse: () => throw ArgumentError.value(
-              value, 'value', 'No enum value with that value'));
+      PositionSource.values.byValue(value);
 }

packages/windows_devices/lib/src/geolocation/positionstatus.dart

@@ -23,7 +23,5 @@ enum PositionStatus implements WinRTEnum {
   const PositionStatus(this.value);
 
   factory PositionStatus.from(int value) =>
-      PositionStatus.values.firstWhere((e) => e.value == value,
-          orElse: () => throw ArgumentError.value(
-              value, 'value', 'No enum value with that value'));
+      PositionStatus.values.byValue(value);
 }

packages/windows_devices/lib/src/gpio/gpiopinedge.dart

@@ -19,8 +19,5 @@ enum GpioPinEdge implements WinRTEnum {
 
   const GpioPinEdge(this.value);
 
-  factory GpioPinEdge.from(int value) =>
-      GpioPinEdge.values.firstWhere((e) => e.value == value,
-          orElse: () => throw ArgumentError.value(
-              value, 'value', 'No enum value with that value'));
+  factory GpioPinEdge.from(int value) => GpioPinEdge.values.byValue(value);
 }

packages/windows_devices/lib/src/sensors/pedometerstepkind.dart

@@ -20,7 +20,5 @@ enum PedometerStepKind implements WinRTEnum {
   const PedometerStepKind(this.value);
 
   factory PedometerStepKind.from(int value) =>
-      PedometerStepKind.values.firstWhere((e) => e.value == value,
-          orElse: () => throw ArgumentError.value(
-              value, 'value', 'No enum value with that value'));
+      PedometerStepKind.values.byValue(value);
 }

packages/windows_foundation/lib/src/asyncstatus.dart

@@ -20,8 +20,5 @@ enum AsyncStatus implements WinRTEnum {
 
   const AsyncStatus(this.value);
 
-  factory AsyncStatus.from(int value) =>
-      AsyncStatus.values.firstWhere((e) => e.value == value,
-          orElse: () => throw ArgumentError.value(
-              value, 'value', 'No enum value with that value'));
+  factory AsyncStatus.from(int value) => AsyncStatus.values.byValue(value);
 }

packages/windows_foundation/lib/src/propertytype.dart

@@ -57,8 +57,5 @@ enum PropertyType implements WinRTEnum {
 
   const PropertyType(this.value);
 
-  factory PropertyType.from(int value) =>
-      PropertyType.values.firstWhere((e) => e.value == value,
-          orElse: () => throw ArgumentError.value(
-              value, 'value', 'No enum value with that value'));
+  factory PropertyType.from(int value) => PropertyType.values.byValue(value);
 }

packages/windows_foundation/lib/src/winrt_enum.dart

@@ -14,6 +14,19 @@ abstract class WinRTEnum {
       _name != null ? '$runtimeType.$_name' : '$runtimeType(value: $value)';
 }
 
+extension WinRTEnumHelper<T extends WinRTEnum> on Iterable<T> {
+  /// Finds the enum value in this list with value [value].
+  ///
+  /// Goes through this collection looking for an enum with value [value].
+  /// Returns the first value with the given value. Such a value must be found.
+  T byValue(int value) {
+    for (final enumValue in this) {
+      if (enumValue.value == value) return enumValue;
+    }
+    throw ArgumentError.value(value, 'value', 'No enum value with that value');
+  }
+}
+
 /// The base class that all WinRT Flags enumerations implement.
 abstract base class WinRTFlagsEnum<T extends WinRTEnum> extends WinRTEnum {
   const WinRTFlagsEnum(super.value, {super.name});

packages/windows_foundation/test/winrt_enum_test.dart

@@ -0,0 +1,39 @@
+// Copyright (c) 2023, Dart | Windows. Please see the AUTHORS file for details.
+// All rights reserved. Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file.
+
+@TestOn('windows')
+
+import 'package:test/test.dart';
+import 'package:windows_foundation/internal.dart';
+import 'package:windows_foundation/windows_foundation.dart';
+import 'package:windows_storage/windows_storage.dart';
+
+void main() {
+  test('WinRTEnum toString', () {
+    expect(AsyncStatus.completed.toString(), equals('AsyncStatus.completed'));
+  });
+
+  group('List<WinRTEnum> byValue', () {
+    test('finds enum values', () {
+      expect(AsyncStatus.values.byValue(0), equals(AsyncStatus.started));
+      expect(AsyncStatus.values.byValue(3), equals(AsyncStatus.error));
+    });
+
+    test('throws ArgumentError for invalid values', () {
+      expect(() => AsyncStatus.values.byValue(4), throwsArgumentError);
+    });
+  });
+
+  group('WinRTFlagsEnum toString', () {
+    test('(1)', () {
+      expect(FileAttributes.directory.toString(),
+          equals('FileAttributes.directory'));
+    });
+
+    test('(2)', () {
+      expect((FileAttributes.directory | FileAttributes.readOnly).toString(),
+          equals('FileAttributes(value: 17)'));
+    });
+  });
+}