Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: some Vector type arguments are now nullable #286

Merged
merged 1 commit into from
Jul 2, 2023
Merged

fix!: some Vector type arguments are now nullable #286

merged 1 commit into from
Jul 2, 2023

Conversation

halildurmus
Copy link
Owner

@halildurmus halildurmus commented Jul 2, 2023 •
edited
Loading

Description

When I initially added support for WinRT Vectors, I was unaware that it was possible for them to contain null elements. However, while working on #285, I discovered that they can indeed contain null elements.

This change only impacts type arguments such as Uri and subtypes of IInspectable (such as StorageFile), while other type arguments remain non-nullable.

Related Issue

Type of Change

  • ✨ feat -- New feature (non-breaking change which adds functionality)
  • 🛠️ fix -- Bug fix (non-breaking change which fixes an issue)
  • ❌ ! -- Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 refactor -- Code refactor
  • ✅ ci -- Build configuration change
  • 📝 docs -- Documentation
  • 🧪 test -- Test
  • 🗑️ chore -- Chore

@halildurmus halildurmus added the breaking change Introduces a breaking change label Jul 2, 2023
@github-actions github-actions bot added pkg: windows_data The windows_data package pkg: windows_devices The windows_devices package pkg: windows_foundation The windows_foundation package pkg: windows_gaming The windows_gaming package pkg: windows_globalization The windows_globalization package pkg: windows_graphics The windows_graphics package pkg: windows_media The windows_media package pkg: windows_networking The windows_networking package pkg: windows_storage The windows_storage package pkg: windows_system The windows_system package pkg: windows_ui The windows_ui package pkg: winrtgen The winrtgen package pkg: windows_security The windows_security package pkg: windows_ai The windows_ai package pkg: windows_applicationmodel The windows_applicationmodel package labels Jul 2, 2023
@halildurmus halildurmus marked this pull request as ready for review July 2, 2023 22:44
@halildurmus halildurmus merged commit 36eef7a into main Jul 2, 2023
9 of 65 checks passed
@halildurmus halildurmus deleted the vector branch July 2, 2023 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking change Introduces a breaking change pkg: windows_ai The windows_ai package pkg: windows_applicationmodel The windows_applicationmodel package pkg: windows_data The windows_data package pkg: windows_devices The windows_devices package pkg: windows_foundation The windows_foundation package pkg: windows_gaming The windows_gaming package pkg: windows_globalization The windows_globalization package pkg: windows_graphics The windows_graphics package pkg: windows_media The windows_media package pkg: windows_networking The windows_networking package pkg: windows_security The windows_security package pkg: windows_storage The windows_storage package pkg: windows_system The windows_system package pkg: windows_ui The windows_ui package pkg: winrtgen The winrtgen package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@halildurmus