Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type information missing for types whose BaseType is referenceTypeModifier #56

Closed
halildurmus opened this issue Jun 4, 2022 · 2 comments

Comments

@halildurmus
Copy link
Owner

halildurmus commented Jun 4, 2022

For example, PhoneNumberFormatter's TryCreate function has an out parameter phoneNumber. TypeIdentifier returns its baseType as referenceTypeModifier but it doesn't have any information regarding its type (typeIdentifier.type returns null).

I did some digging and I found this code: https://github.com/timsneath/winmd/blob/b8920329a0882bae60ae061004f27860491c3d5d/lib/src/utils/typetuple.dart#L46-L51

For phoneNumber parameter, signatureBlob[1] returns 18 (0x12) which equals to ELEMENT_TYPE_CLASS . I tried a few things but couldn't figure it out, this is too complex for me.

Can you take a look at these when you have a chance?

@timsneath
Copy link
Contributor

On a flight this afternoon, will take a look at this then!

@timsneath
Copy link
Contributor

Fixed in #57 and published as v2.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants