Make .remove chainable

DarthJDG · Sep 5, 2016 · 51b60f1 · 51b60f1
1 parent bd1065f
commit 51b60f1
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 14 deletions.
diff --git a/mangler.js b/mangler.js
@@ -1127,11 +1127,8 @@ var Mangler = (function(global) {
 
 		remove: function(item) {
 			var i = this.items.indexOf(item);
-			if(i > -1) {
-				this.items.splice(i, 1);
-				return true;
-			}
-			return false;
+			if(i > -1) this.items.splice(i, 1);
+			return this;
 		},
 
 		rename: function(dict) {

diff --git a/test/test.js b/test/test.js
@@ -1206,18 +1206,14 @@
 	});
 
 	QUnit.test('.remove', function(assert) {
-		assert.expect(8);
+		assert.expect(4);
 
 		var m = Mangler(['A', 'B', 'C']);
 
-		assert.strictEqual(m.remove('B'), true, 'passed');
-		assert.deepEqual(m.items, ['A', 'C'], 'passed');
-		assert.strictEqual(m.remove('D'), false, 'passed');
-		assert.deepEqual(m.items, ['A', 'C'], 'passed');
-		assert.strictEqual(m.remove('A'), true, 'passed');
-		assert.deepEqual(m.items, ['C'], 'passed');
-		assert.strictEqual(m.remove('C'), true, 'passed');
-		assert.deepEqual(m.items, [], 'passed');
+		assert.deepEqual(m.remove('B').items, ['A', 'C'], 'passed');
+		assert.deepEqual(m.remove('D').items, ['A', 'C'], 'passed');
+		assert.deepEqual(m.remove('A').items, ['C'], 'passed');
+		assert.deepEqual(m.remove('C').items, [], 'passed');
 	});
 
 	QUnit.test('.rename', function(assert) {