Skip to content
This repository has been archived by the owner on Sep 15, 2022. It is now read-only.

Port Dartino to MIPS32 platforms #496

Closed
petar-jovanovic opened this issue May 13, 2016 · 4 comments
Closed

Port Dartino to MIPS32 platforms #496

petar-jovanovic opened this issue May 13, 2016 · 4 comments

Comments

@petar-jovanovic
Copy link
Contributor

Given the popularity, presence and energy efficiency of MIPS CPUs in embedded systems, we believe support for MIPS CPUs in Dartino is of great importance. For this reason, RT-RK has done a port of Dartino for MIPS, and we would like to discuss it with you, get your feedback on the code and changes, and hopefully merge it into the trunk after reviews.

You can find the initial port at the link below and instructions for trying it out at one of the wiki pages.

Looking forward to hearing back from you on this!

Refs.
[1] MIPS on Dartino, code, https://github.com/petar-jovanovic/sdk/tree/mips-dev
[2] Getting started with MIPS Dartino, https://github.com/petar-jovanovic/sdk/wiki/Getting-started-with-MIPS-Dartino

@sgjesse
Copy link
Contributor

sgjesse commented May 17, 2016

Thanks a lot for working on this!

I will try it out shortly, but I don't see any blockers for landing MIPS support in the tree.

For a change of this size, we would appreciate, if you can upload the patch(es) using git cl upload for reviewing in Rietveld (https://codereview.chromium.org/) for the actual code review.

From your Git repository the change is already split into 5 different patches, which might work well for landing as well.

@petar-jovanovic
Copy link
Contributor Author

First patch uploaded at
https://codereview.chromium.org/2006403003/

sgjesse added a commit that referenced this issue May 30, 2016
Initial code (first patch) to be able to build Dartino for MIPS32 arch.

BUG= #496
TEST= ninja -C out/DebugXMIPS

Review URL: https://codereview.chromium.org/2006403003 .
@petar-jovanovic
Copy link
Contributor Author

Second patch uploaded at
https://codereview.chromium.org/2029943003/

sgjesse added a commit that referenced this issue Jun 8, 2016
Implement prologue/epilogue and dispatch through table in MIPS native
interpreter.

Patch by RT-RK.

BUG= #496
TEST= ninja -C out/DebugXMIPS

Review URL: https://codereview.chromium.org/2029943003 .
ErikCorryGoogle pushed a commit that referenced this issue Jun 20, 2016
Implement enough bytecodes to run

main() {
  var number = 42;
  print('$number');
}

Patch by RT-RK.

BUG= #496
TEST= ninja -C out/DebugXMIPS
R=erikcorry@google.com

Review URL: https://codereview.chromium.org/2074483004 .

Patch from "RT-RK" <petarj@mips.com>.
ErikCorryGoogle pushed a commit that referenced this issue Jun 29, 2016
With this change, MIPS Dartino can run hello.dart from samples/general/.

Also, this change incorporates some ARM changes from

> More compact snapshots
> https://codereview.chromium.org/2067483002/

Patch by RT-RK.

BUG= #496
TEST= ninja -C out/DebugXMIPS

Review URL: https://codereview.chromium.org/2088133005 .

Patch from "RT-RK" <petarj@mips.com>.
ErikCorryGoogle pushed a commit that referenced this issue Aug 1, 2016
With this change, majority of the tests pass for MIPS.
The change also includes improvements over AddIf function to generate
a little bit more optimized code for specific cases.

Patch by RT-RK.

BUG= #496
TEST= ninja -C out/DebugXMIPS
R=erikcorry@google.com

Review URL: https://codereview.chromium.org/2173123003 .

Patch from "RT-RK" <petarj@mips.com>.
ErikCorryGoogle pushed a commit that referenced this issue Aug 10, 2016
Values such as socket constants and types are arch-specific and can
only be resolved at runtime.

Patch by RT-RK.

BUG= #496
TEST= ninja -C out/DebugXMIPS
R=erikcorry@google.com

Review URL: https://codereview.chromium.org/2203023002 .

Patch from "RT-RK" <petarj@mips.com>.
@petar-jovanovic
Copy link
Contributor Author

This issue can be closed as fixed. Since the last change was committed 23 days ago, all tests pass for QEMU MIPS32.

[45:05 | 100% | + 5283 | - 0]

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

3 participants