Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to core handling #37

Open
dartiss opened this issue Feb 3, 2023 · 1 comment
Open

Update to core handling #37

dartiss opened this issue Feb 3, 2023 · 1 comment
Assignees
Milestone

Comments

@dartiss
Copy link
Owner

dartiss commented Feb 3, 2023

Okay, so bear with me, this is a big one.

Since WP4.9, core has done the housekeeping itself (why the hell didn't anybody tell me?). Here's the code... https://github.com/WordPress/WordPress/blob/e5b8662000b53dfdf734bef83eb2b02facfabb16/wp-includes/option.php#L1028

It hooks into the daily trash collection here: https://github.com/WordPress/WordPress/blob/b8bc65042ab4c57cefc46bbf9eb8d56e00188dee/wp-admin/admin.php#L106. Oh, and it does it on upgrade too. Basically, what my plugin does. Plus it handles some other things better than I do.

So, with this release I want to use what'a already there and add a few extras on from mine. Basically, the ability to run them ad-hoc. To do this, I need to call delete_expired_transients. What I'll loose is the ability to report on when it last ran.

This will also limit the options - the ability to run, plus the ability to optimise afterwards. Also provide the ability to clear all transients too.

@dartiss dartiss added this to the 2.0 milestone Feb 3, 2023
@dartiss dartiss self-assigned this Dec 2, 2023
@dartiss
Copy link
Owner Author

dartiss commented Jun 13, 2024

Will move minimum version of WP for this plugin to 4.9 and exclusively use the core function to do the housekeeping.

As a result I will remove certain settings, such as defining when the housekeeping will run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant