Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Currently the darwin community can cancel an airdrop, who gets the refund in that case #12

Closed
kingofclubstroyDev opened this issue Dec 5, 2022 · 6 comments
Closed

Currently the darwin community can cancel an airdrop, who gets the refund in that case #12

kingofclubstroyDev opened this issue Dec 5, 2022 · 6 comments

Comments

@kingofclubstroyDev
Copy link
Contributor

At the moment the community and the airdrop owner can cancel a given airdrop, if you want the community to be able to do that, who gets sent the refund tokens, currently it is msg.sender, but I think it should always go to the creator of the airdrop
@kingofclubstroyDev
Copy link
Contributor Author

I send the tokens back to the airdrop creator now. I will leave this open in case that needs to change

@SomeTimesIInvent
Copy link

SomeTimesIInvent commented Dec 6, 2022 •
edited
Loading

Yeah going back to the creator makes sense.

@SomeTimesIInvent
Copy link

As for airdrops themselves and who can cancel them. We don't want to give the community that power.

We have to make sure that the community have as little control over use cases as possible as it causes legal issues.

And to be honest I want us to have as little control as possible to make them as decentralised as we can.

@SomeTimesIInvent
Copy link

Has this been changed so only the airdrop creator can cancel an airdrop?

@SomeTimesIInvent
Copy link

Could you check this please @SmartGambleDev ?

We want it so only the airdrop creator can cancel the airdrop and when they do the funds are sent back to them.

ghost pushed a commit that referenced this issue Dec 28, 2022
Resolved issue #12
d802508
@ghost
Copy link

ghost commented Dec 28, 2022

Solved. Removed community from being able to cancel an airdrop (only its creator can). When canceled, funds are sent to the airdrop creator.

@ghost ghost closed this as completed Dec 28, 2022
ghost pushed a commit that referenced this issue Dec 28, 2022
Resolved issue #12 - pt.2
ea6bbef 
Not sending fees to airdropOwner when they cancel the airdrop
ghost pushed a commit that referenced this issue Dec 28, 2022
Resolved issue #12 - final
62a1790 
If the creator cancels an airdrop less than `recoverFeesDeadline` seconds after they created it, they get the paid fees back. The variable is settable thru the function `setRecoverFeesDeadline`
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SomeTimesIInvent @kingofclubstroyDev