Skip to content
This repository has been archived by the owner on Mar 13, 2023. It is now read-only.

Check message fee from the fee-market by customizing LaneMessageVerifier #862

Closed
hackfisher opened this issue Oct 14, 2021 · 4 comments · Fixed by #870
Closed

Check message fee from the fee-market by customizing LaneMessageVerifier #862

hackfisher opened this issue Oct 14, 2021 · 4 comments · Fixed by #870
Assignees

Comments

@hackfisher
Copy link
Contributor

type LaneMessageVerifier = ToPangolinMessageVerifier;

@xiaoch05
Copy link
Contributor

The minimize size of the relayers can also be checked here?

@boundless-forest
Copy link
Member

The minimize size of the relayers can also be checked here?

The minimum fee market relayers number will be checked once the rpc can get the market fee. If query market fee return None, that also means the fee market relayers is not enough.

@xiaoch05
Copy link
Contributor

The minimize size of the relayers can also be checked here?

The minimum fee market relayers number will be checked once the rpc can get the market fee. If query market fee return None, that also means the fee market relayers is not enough.

This restriction is good for the next process of the order. Then I think we will have no problem with this issue #863. Because users have no chance to send such messages without an order.

@boundless-forest boundless-forest changed the title Support checking message fee from replayer fee market by customizing LaneMessageVerifier Check message fee from the fee-market by customizing LaneMessageVerifier Oct 18, 2021
@boundless-forest
Copy link
Member

Then I think we will have no problem with this issue #863. Because users have no chance to send such messages without an order.

You are right. There is a test case example https://github.com/darwinia-network/darwinia-common/blob/bear-check-market-fee/frame/fee-market/src/tests.rs#L828

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants