Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better alternative naming of RuntimeTransact? #1426

Closed
hackfisher opened this issue Mar 4, 2024 · 0 comments · Fixed by #1428
Closed

Better alternative naming of RuntimeTransact? #1426

hackfisher opened this issue Mar 4, 2024 · 0 comments · Fixed by #1428
Assignees
Labels
P-Low [Priority] Low U-Help Wanted [Uncategorized] Extra attention is needed U-Housekeeping [Uncategorized] Housekeeping works which doesn't touch the logic

Comments

@hackfisher
Copy link
Contributor

          For the naming, I think runtime transact looks good for me because this indicates the source of this tx is from called from runtime to EVM executor, distinguishing it from ordinary evm transact using ecdsa unsigned extrinsic. Alternative naming would better to find a replacement for the runtime, `internal`, `system`, `private`?

Did we make test pass on the Pangolin yet?

Originally posted by @hackfisher in #1421 (review)

@hackfisher hackfisher added U-Help Wanted [Uncategorized] Extra attention is needed P-Low [Priority] Low U-Housekeeping [Uncategorized] Housekeeping works which doesn't touch the logic labels Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-Low [Priority] Low U-Help Wanted [Uncategorized] Extra attention is needed U-Housekeeping [Uncategorized] Housekeeping works which doesn't touch the logic
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants