Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for border in ignore #16

Closed
lutien opened this issue Dec 16, 2019 · 7 comments
Closed

Support for border in ignore #16

lutien opened this issue Dec 16, 2019 · 7 comments

Comments

@lutien
Copy link

lutien commented Dec 16, 2019

Is there any specific reason why border property can not be ignored?
If it is possible in theory I could make a PR to support that 🙂

@lutien
Copy link
Author

lutien commented Dec 16, 2019

Created a PR already 🙂

@darwintantuco
Copy link
Owner

darwintantuco commented Dec 31, 2019

Sorry for the late response.

Honestly, I'm not sure how to go about this at first so I search and found this article:
https://builttoadapt.io/8-point-grid-borders-and-layouts-e91eb97f5091?gi=d9953d055d8d
It's a great article and it explain well how to go about border on 8-point grid

I'm leaning towards using the second approach (as said in the article):
allowing the 1px border to hold space outside of the 8px internal padding
So I think there's no need to apply 8 point grid on borders.

Also, by using box-sizing: border-box, it will include border and padding on final width and height of the element.

@darwintantuco
Copy link
Owner

Also, I think it's uncommon to use large values for border-width
Usually, it's 1px 2px, 4px etc

@lutien
Copy link
Author

lutien commented Jan 6, 2020

@dcrtantuco, I think I probably understood something wrong then 🙂 Do you mean that at the moment border width will not be affected by the plugin?

@darwintantuco
Copy link
Owner

yes! it doesn't include border width at the moment.

@lutien
Copy link
Author

lutien commented Jan 7, 2020

@dcrtantuco, cool! thank you for the response! Then I'll close my PR 🙂

@darwintantuco
Copy link
Owner

welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants