Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CSS Logical Properties #38

Closed
kcastellino opened this issue Sep 30, 2022 · 3 comments · Fixed by #39
Closed

Add support for CSS Logical Properties #38

kcastellino opened this issue Sep 30, 2022 · 3 comments · Fixed by #39

Comments

@kcastellino
Copy link

Hi,

Adding support for CSS Logical Properties was previously mentioned in issue #28, but I feel a separate tracking issue is warranted, as logical properties are well-defined and widely supported, and the scope of that issue is much larger. Logical properties allow for spacing and layout to automatically adjust based on the writing system, and the number of logical properties (such as padding-inline-start and margin-block-end, which for English pages correspond to padding-left and margin-bottom) is similar to the exisiting number of positional properties.

The simplest option would be to add the logical properties corresponding to supported physical properties to the supportedCssProperties array. If you like, I'd be happy to write up a pull request with the modifications and tests. Otherwise, let me know if you need more info.

@darwintantuco
Copy link
Owner

thank you for creating an issue, I totally forgot about this

initial PR: #39

@darwintantuco
Copy link
Owner

I haven't used css logical properties yet, it's possible I missed some properties 😅

@kcastellino
Copy link
Author

Yep, looks like you covered them all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants