-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Not all follows retrieved #14
Comments
ngl. I never expected anyone to have this many follows. |
api seems to have problems with offset values (there seems to be an edge case where you cant get just the last followed manga). i think this will take awhile to fix |
@scott-tancock i will be releasing a test build addressing this issue soon. will also have an added feature for pagination (loading 800+ follows on a single page would probably burn down someone's PC and their home). |
You may test out the alpha release here: https://github.com/darylhjd/mangadesk/releases/tag/v0.2-alpha |
Seems to be working to me. Fetches all 812 Manga, and each item can be accessed as normal. Few odd quirks with the
^ Those are all just minor matters. If no-one else is having an issue with this patch, the issue can be closed. Pretty impressive how fast you fixed this. |
1st point:
2nd point:
3rd point:
4th point:
|
Issue
When logged in, only the first 50 followed manga are fetched from Mangadex
Expected behaviour: After logging in, all followed manga are retrieved
Actual behaviour: After logging in, only 50 followed manga are retrieved
Steps to reproduce: Log in to an account with > 50 followed manga
Additional info: Looks like you're only sending one request to the server with limit=50. Instead, you should read the 'total' token returned at the end of the list of manga and loop the fetch with offset = offset + limit each time.
Example
Evidence
Fetched manga (50 counted):
![image](https://user-images.githubusercontent.com/27858273/118412018-9fa68100-b68f-11eb-874d-e6007cd8eed3.png)
![image](https://user-images.githubusercontent.com/27858273/118412079-ec8a5780-b68f-11eb-9edc-05c325861397.png)
Response from the sever using Postman (812 follows total):
The text was updated successfully, but these errors were encountered: