Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Custom Command] Added my own selection command #19

Closed
nayomi3i opened this issue May 23, 2021 · 2 comments
Closed

[Custom Command] Added my own selection command #19

nayomi3i opened this issue May 23, 2021 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@nayomi3i
Copy link

nayomi3i commented May 23, 2021

I don't really know if I implemented it correctly since I had to try to teach myself Go from nothing just to make it in only like, a day. But I found the whole, Cmd+E, next, Cmd+E, tedious and wanted to implement a Select All. I found a work around, I think maybe someone would find it useful or you could implement yourself in a more robust way. Anyways, this is it,

I don't know how to use git so I'm probably showing this wrong 😅
And also since I'm not experienced in Go I didn't want to do git pull or anything like that (don't know how and might do it wrong), the command is just for personal use and it might be cool if it was proper.

MangaHandler

CustomFunction

functionality.mp4
@nayomi3i
Copy link
Author

It would be nice to add some kind of language filter to the mangalist. I don't know how to work with the API so I don't know if I could implement it myself. But possibly add something like, a new page that you can do like ctrl+[someKey] that will find all of the available languages, allow you to select a language, and then filter shown chapters like that?

I really don't know, but thatd be convenient.

@darylhjd darylhjd added the enhancement New feature or request label May 24, 2021
@darylhjd
Copy link
Owner

darylhjd commented May 24, 2021

Welcome to the Golang community :)

Working with Git may be scary but it is easy once you get a hang of it. Here are the steps:

  1. Fork the current repository that you want to contribute to.
    • This will add a copy of the repository into your own account.
  2. Add your features/bug fixes into your forked repository.
    • Remember to push your changes into the repository!
  3. Once you are happy with the changes, head on over to the current repository's Pull Requests tab.
    • Then, create a new pull request.
    • Click Compare across forks.
  4. Choose the base repository to pull into (the repo you want to contribute to), and the head repository to push from (this is where you select your forked repo that you have made changes to).
    • Remember to read the contributing guidelines for whichever repo you want to contribute to.

I have already implemented the requests you asked for. However, you may feel free to practice!
You can try forking, making changes and then submitting a pull request to see how the process works.

You do not need to worry about breaking something, as I will need to approve the request. If I don't, nothing will happen.

@darylhjd darylhjd added the good first issue Good for newcomers label May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants