Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Packet could use header strategy #66

Closed
lambdafu opened this issue Apr 12, 2018 · 0 comments · Fixed by #76
Closed

Packet could use header strategy #66

lambdafu opened this issue Apr 12, 2018 · 0 comments · Fixed by #76

Comments

@lambdafu
Copy link
Collaborator

lambdafu commented Apr 12, 2018 •
edited

Currently, we can not influence the way headers are generated. So tests for old style headers need to count bytes manually and set a custom header.

Having different strategies (old vs new, adaptive length type vs fixed length type) could help with that.

Could also be useful to generate backward compatible output with certain compliance profiles.

The custom header could then be one of the strategies. So the solution would likely be a header strategy class (ouch) that comes in different flavors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow to set header factory when writing packets. das-labor/neopg
1 participant
@lambdafu