Compiler warnings

[tobiasschweizer]

[info] Compiling 402 Scala sources to .../webapi/target/scala-2.12/classes ...
[warn] .../webapi/src/main/scala/org/knora/webapi/store/triplestore/embedded/JenaTDBActor.scala:441:49: class RAMDirectory in package store is deprecated: see corresponding Javadoc for more information.
[warn]             val indexDirectory: Directory = new RAMDirectory()
[warn]                                                 ^
[warn] .../webapi/src/main/scala/org/knora/webapi/store/triplestore/embedded/JenaTDBActor.scala:452:49: class RAMDirectory in package store is deprecated: see corresponding Javadoc for more information.
[warn]             val indexDirectory: Directory = new RAMDirectory()
[warn]                                                 ^
[warn] two warnings found

[tobiasschweizer]

I got these warnings on #1379

[benjamingeer]

This is also fixed in #1403: https://github.com/dhlab-basel/Knora/pull/1403/files#diff-d36235129cdb679e49e12100b7f9e8d9

[subotic]

Great, was easy to fix :-)

[tobiasschweizer]

This is also fixed in #1403: https://github.com/dhlab-basel/Knora/pull/1403/files#diff-d36235129cdb679e49e12100b7f9e8d9

Great!

I think such fixes should rather be done in small and quick PRs since #1403 will be pending for a while. Or was it specifically related to #1403?

[benjamingeer]

Or was it specifically related to #1403?

It's caused by the upgrade of the RDF4J library in #1403.

[tobiasschweizer]

It's caused by the upgrade of the RDF4J library in #1403.

Was the upgrade of the RDF4J library specifically related to #1403? ;-)

[benjamingeer]

Was the upgrade of the RDF4J library specifically related to #1403? ;-)

Yes, it fixes a stack-overflow error in RDF4J which was triggered by changing a test in #1403.

[tobiasschweizer]

Ok, got it. Thanks for the explanation!

[benjamingeer]

... and the only reason you're getting the warning is because you copied the RDF4J upgrade from #1403.