Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CORS): explicitly assign allowed CORS methods #2443

Merged
merged 3 commits into from Feb 14, 2023

Conversation

mdelez
Copy link
Contributor

@mdelez mdelez commented Feb 14, 2023

Pull Request Checklist

Task Description/Number

Using the default anyMethod parameter doesn't work for PUT or DELETE requests. This PR explicitly assigns which CORS methods are allowed.

Basic Requirements

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • fix: represents bug fixes
  • refactor: represents production code refactoring
  • feat: represents a new feature
  • docs: documentation changes (no production code change)
  • chore: maintenance tasks (no production code change)
  • test: all about tests: adding, refactoring tests (no production code change)
  • other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No
  • Maybe (not 100% sure => check with FE)

Does this PR change client-test-data?

  • Yes (don't forget to update the JS-LIB team about the change)
  • No

@mdelez mdelez added the bug something isn't working label Feb 14, 2023
@mdelez mdelez self-assigned this Feb 14, 2023
@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Base: 9.67% // Head: 9.67% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (75f82d1) compared to base (dc8b4b5).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##            main   #2443      +/-   ##
========================================
- Coverage   9.67%   9.67%   -0.01%     
========================================
  Files        283     283              
  Lines      29373   29375       +2     
========================================
  Hits        2841    2841              
- Misses     26532   26534       +2     
Impacted Files Coverage Δ
...main/scala/org/knora/webapi/core/HttpServerZ.scala 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

@irinaschubert irinaschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy first contribution! 🥳

@mdelez mdelez added this pull request to the merge queue Feb 14, 2023
Merged via the queue into main with commit 99fe6fa Feb 14, 2023
@mdelez mdelez deleted the wip/fix-cors-allowed-methods branch February 14, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants