New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Ziofy ProjectsResponderADM DEV-1728 #2459
Conversation
Codecov ReportBase: 9.69% // Head: 86.51% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2459 +/- ##
==========================================
+ Coverage 9.69% 86.51% +76.82%
==========================================
Files 285 287 +2
Lines 29491 29487 -4
==========================================
+ Hits 2858 25510 +22652
+ Misses 26633 3977 -22656
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
4342fe3
to
28d5e6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one minor suggestion, feel free to ignore it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one. Just please answer my questions and check cosmetic suggestions:
webapi/src/main/scala/org/knora/webapi/responders/admin/ProjectsResponderADM.scala
Show resolved
Hide resolved
webapi/src/main/scala/org/knora/webapi/responders/admin/ProjectsResponderADM.scala
Show resolved
Hide resolved
webapi/src/main/scala/org/knora/webapi/responders/admin/ProjectsResponderADM.scala
Show resolved
Hide resolved
webapi/src/main/scala/org/knora/webapi/responders/admin/ProjectsResponderADM.scala
Show resolved
Hide resolved
webapi/src/main/scala/org/knora/webapi/responders/admin/ProjectsResponderADM.scala
Show resolved
Hide resolved
* Executes the effect synchronously and returns its result as a | ||
* [[A]] value or throws a [[FiberFailure]]. | ||
* | ||
* This method is effectful and should only be used at the edges of your |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess effectful
in terms of ZIO, but could you be more specific here maybe?
af26235
to
7474f07
Compare
Pull Request Checklist
Task Description/Number
Issue Number: DEV-1728
Migrates the
ProjectsResponderADM
into ZIO land.ProjectsResponderADM
trait which exposes the methods from the receive/handle to the outside world for possible direct useIriLocker
ZioHelper
object which implements functions forZIO
s akin to Scala'sFuture#sequence
functionsTriplestore#sparqlHttpExtendedConstruct
methods which accepts aString
ActorUtil#zio2Message
, all causes are sent back to the actor as failurePR is based on #2453 that is why I have set this as the merge target for now so that you do not have to review the other PR twice.
Basic Requirements
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR change client-test-data?