Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: ziofy Cache (DEV-1824) #2512

Merged
merged 15 commits into from Mar 9, 2023
Merged

refactor: ziofy Cache (DEV-1824) #2512

merged 15 commits into from Mar 9, 2023

Conversation

seakayone
Copy link
Collaborator

@seakayone seakayone commented Mar 8, 2023

Pull Request Checklist

Task Description/Number

Issue Number: DEV-1824

  • ziofy Cache
  • Merge Cache with OntologyCache implementation in slice

Basic Requirements

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • fix: represents bug fixes
  • refactor: represents production code refactoring
  • feat: represents a new feature
  • docs: documentation changes (no production code change)
  • chore: maintenance tasks (no production code change)
  • test: all about tests: adding, refactoring tests (no production code change)
  • other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No
  • Maybe (not 100% sure => check with FE)

Does this PR change client-test-data?

  • Yes (don't forget to update the JS-LIB team about the change)
  • No

@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Patch coverage: 95.67% and project coverage change: +0.01 🎉

Comparison is base (1cf4727) 86.63% compared to head (55d294e) 86.65%.

❗ Current head 55d294e differs from pull request most recent head e768944. Consider uploading reports for the commit e768944 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2512      +/-   ##
==========================================
+ Coverage   86.63%   86.65%   +0.01%     
==========================================
  Files         287      286       -1     
  Lines       29896    29985      +89     
==========================================
+ Hits        25901    25984      +83     
- Misses       3995     4001       +6     
Impacted Files Coverage Δ
webapi/src/main/scala/org/knora/webapi/Main.scala 0.00% <0.00%> (ø)
...c/main/scala/org/knora/webapi/core/AppRouter.scala 100.00% <ø> (ø)
...la/org/knora/webapi/core/actors/RoutingActor.scala 94.73% <ø> (ø)
...SpecificGravsearchToCountPrequeryTransformer.scala 91.66% <ø> (ø)
...storeSpecificGravsearchToPrequeryTransformer.scala 91.56% <ø> (ø)
...ravsearch/types/GravsearchTypeInspectionUtil.scala 93.82% <ø> (ø)
...knora/webapi/responders/v2/SearchResponderV2.scala 90.43% <ø> (ø)
...slice/ontology/repo/service/OntologyRepoLive.scala 88.23% <50.00%> (ø)
.../src/main/scala/org/knora/webapi/util/Logger.scala 91.66% <91.66%> (ø)
...ora/webapi/responders/v2/OntologyResponderV2.scala 91.72% <95.71%> (+0.09%) ⬆️
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@seakayone seakayone changed the title wip // ziofy Cache refactor: ziofy Cache (DEV-1824) Mar 9, 2023
@linear
Copy link

linear bot commented Mar 9, 2023

@seakayone seakayone force-pushed the wip/ziofy-cache branch 2 times, most recently from c580fdb to 6e4e5c8 Compare March 9, 2023 10:10
@seakayone seakayone marked this pull request as ready for review March 9, 2023 11:53
@seakayone seakayone requested review from irinaschubert and BalduinLandolt and removed request for irinaschubert March 9, 2023 11:53
Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@seakayone seakayone merged commit 1daeb55 into main Mar 9, 2023
@seakayone seakayone deleted the wip/ziofy-cache branch March 9, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants