Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: minor improvements to permissions documentation #2520

Merged
merged 6 commits into from Mar 14, 2023

Conversation

BalduinLandolt
Copy link
Collaborator

@BalduinLandolt BalduinLandolt commented Mar 13, 2023

Pull Request Checklist

Task Description/Number

Issue Number: None

Basic Requirements

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • fix: represents bug fixes
  • refactor: represents production code refactoring
  • feat: represents a new feature
  • docs: documentation changes (no production code change)
  • chore: maintenance tasks (no production code change)
  • test: all about tests: adding, refactoring tests (no production code change)
  • other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No
  • Maybe (not 100% sure => check with FE)

Does this PR change client-test-data?

  • Yes (don't forget to update the JS-LIB team about the change)
  • No

Copy link
Collaborator

@mpro7 mpro7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just question about Knora, should it be DSP-API instead?

@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Patch coverage: 96.43% and project coverage change: +0.07 🎉

Comparison is base (1cf4727) 86.63% compared to head (57388dc) 86.70%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2520      +/-   ##
==========================================
+ Coverage   86.63%   86.70%   +0.07%     
==========================================
  Files         287      286       -1     
  Lines       29896    30005     +109     
==========================================
+ Hits        25901    26017     +116     
+ Misses       3995     3988       -7     
Impacted Files Coverage Δ
webapi/src/main/scala/org/knora/webapi/Main.scala 0.00% <0.00%> (ø)
...c/main/scala/org/knora/webapi/core/AppRouter.scala 100.00% <ø> (ø)
...la/org/knora/webapi/core/actors/RoutingActor.scala 94.11% <ø> (-0.62%) ⬇️
...SpecificGravsearchToCountPrequeryTransformer.scala 91.66% <ø> (ø)
...storeSpecificGravsearchToPrequeryTransformer.scala 91.56% <ø> (ø)
...ravsearch/types/GravsearchTypeInspectionUtil.scala 93.82% <ø> (ø)
...esponder/ontologymessages/OntologyMessagesV2.scala 87.44% <ø> (+0.13%) ⬆️
...ora/webapi/responders/v2/OntologyResponderV2.scala 91.60% <ø> (-0.03%) ⬇️
...slice/ontology/repo/service/OntologyRepoLive.scala 88.23% <50.00%> (ø)
.../src/main/scala/org/knora/webapi/util/Logger.scala 92.00% <92.00%> (ø)
... and 20 more

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@BalduinLandolt
Copy link
Collaborator Author

Just question about Knora, should it be DSP-API instead?

you're right, I missed some instances. (except of course knora-base and knora-admin where changing it would be a bigger thing)

@@ -65,6 +65,7 @@ nav:
- 0004 Change Triplestore Service Manager and Fuseki implementation to ZLayer: 05-internals/design/adr/ADR-0004-change-triplestore-service-manager-and-fuseki-implementation-to-zlayer.md
- 0005 Change ResponderManager to a simple case class: 05-internals/design/adr/ADR-0005-change-respondermanager-to-a-simple-case-class.md
- 0006 Gradually Replace AKKA-HTTP with ZIO-HTTP: 05-internals/design/adr/ADR-0006-use-zio-http.md
- 0007 ZIO-fication of Responders: 05-internals/design/adr/ADR-0007-zio-fication-of-responders.md
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good finding! Thanks, I seem to have missed that when adding the document.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only found it because I ran the docs locally, and then it shows warnings for unused files :)

@BalduinLandolt BalduinLandolt merged commit e434f2c into main Mar 14, 2023
11 checks passed
@BalduinLandolt BalduinLandolt deleted the wip/tidy-up-admin-documentation branch March 14, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants