Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use copy instead of move for Sipi file migration #2655

Merged
merged 1 commit into from May 9, 2023

Conversation

irinaschubert
Copy link

@irinaschubert irinaschubert commented May 9, 2023

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

Basic Requirements

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • fix: represents bug fixes
  • refactor: represents production code refactoring
  • feat: represents a new feature
  • docs: documentation changes (no production code change)
  • chore: maintenance tasks (no production code change)
  • test: all about tests: adding, refactoring tests (no production code change)
  • other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No
  • Maybe (not 100% sure => check with FE)

Does this PR change client-test-data?

  • Yes (don't forget to update the JS-LIB team about the change)
  • No

@irinaschubert irinaschubert self-assigned this May 9, 2023
@irinaschubert irinaschubert marked this pull request as ready for review May 9, 2023 09:59
Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@irinaschubert irinaschubert enabled auto-merge (squash) May 9, 2023 10:01
@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Patch coverage: 25.64% and project coverage change: +0.06 🎉

Comparison is base (5eaf212) 18.11% compared to head (3721a57) 18.18%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2655      +/-   ##
==========================================
+ Coverage   18.11%   18.18%   +0.06%     
==========================================
  Files         272      277       +5     
  Lines       28871    28900      +29     
==========================================
+ Hits         5231     5255      +24     
- Misses      23640    23645       +5     
Impacted Files Coverage Δ
webapi/src/main/scala/dsp/config/AppConfig.scala 0.00% <ø> (ø)
...i/src/main/scala/dsp/valueobjects/LangString.scala 100.00% <ø> (ø)
...c/main/scala/dsp/valueobjects/SchemaCommands.scala 100.00% <ø> (ø)
...la/org/knora/webapi/messages/StringFormatter.scala 51.87% <ø> (-0.10%) ⬇️
.../scala/org/knora/webapi/messages/XmlPatterns.scala 100.00% <ø> (ø)
...sponder/projectsmessages/ProjectsMessagesADM.scala 43.44% <ø> (ø)
...min/responder/usersmessages/UsersMessagesADM.scala 39.81% <0.00%> (-3.27%) ⬇️
...api/messages/store/sipimessages/SipiMessages.scala 0.00% <0.00%> (ø)
...a/webapi/messages/util/search/QueryTraverser.scala 1.28% <ø> (+0.15%) ⬆️
...ravsearch/prequery/AbstractPrequeryGenerator.scala 0.00% <ø> (ø)
... and 36 more

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@irinaschubert irinaschubert merged commit 1b8ffff into main May 9, 2023
13 checks passed
@irinaschubert irinaschubert deleted the wip/use-copy-for-file-migration branch May 9, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants