Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sipi): add clean temp dir cronjob (DEV-2090) #2656

Merged
merged 8 commits into from May 15, 2023

Conversation

SamuelBoerlin
Copy link
Contributor

Pull Request Checklist

Task Description/Number

Issue Number: DEV-2090

Basic Requirements

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • fix: represents bug fixes
  • refactor: represents production code refactoring
  • feat: represents a new feature
  • docs: documentation changes (no production code change)
  • chore: maintenance tasks (no production code change)
  • test: all about tests: adding, refactoring tests (no production code change)
  • other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No
  • Maybe (not 100% sure => check with FE)

Does this PR change client-test-data?

  • Yes (don't forget to update the JS-LIB team about the change)
  • No

@linear
Copy link

linear bot commented May 9, 2023

DEV-2090 Set up a cronjob to call the clean_temp_dir route regularly

The route requires basic auth and expects the credentials to be set with environment variables (CLEAN_TMP_DIR_USER and CLEAN_TMP_DIR_PW)

@SamuelBoerlin SamuelBoerlin marked this pull request as ready for review May 9, 2023 13:55
@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.02 🎉

Comparison is base (82e53ee) 18.12% compared to head (db50ce4) 18.15%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2656      +/-   ##
==========================================
+ Coverage   18.12%   18.15%   +0.02%     
==========================================
  Files         277      277              
  Lines       28958    28958              
==========================================
+ Hits         5248     5256       +8     
+ Misses      23710    23702       -8     
Impacted Files Coverage Δ
...la/org/knora/webapi/routing/v2/SearchRouteV2.scala 0.00% <0.00%> (ø)

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

@irinaschubert irinaschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests didn't run through. Would you like to have a look or should I?

@SamuelBoerlin
Copy link
Contributor Author

Thanks!

@SamuelBoerlin SamuelBoerlin enabled auto-merge (squash) May 15, 2023 07:54
@SamuelBoerlin SamuelBoerlin merged commit 7af1c27 into main May 15, 2023
13 checks passed
@SamuelBoerlin SamuelBoerlin deleted the feature/dev-2090-tmp-clean-cronjob branch May 15, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants