Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add more gravsearch metrics #2666

Merged
merged 5 commits into from May 16, 2023

Conversation

BalduinLandolt
Copy link
Collaborator

@BalduinLandolt BalduinLandolt commented May 15, 2023

Pull Request Checklist

Task Description/Number

This PR does 2 things:

  1. it improves the already reported gravsearch metrics (histogram)
  2. it adds a different metric (summary) to see if this works better/worse on datadog

Basic Requirements

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • fix: represents bug fixes
  • refactor: represents production code refactoring
  • feat: represents a new feature
  • docs: documentation changes (no production code change)
  • chore: maintenance tasks (no production code change)
  • test: all about tests: adding, refactoring tests (no production code change)
  • other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No
  • Maybe (not 100% sure => check with FE)

Does this PR change client-test-data?

  • Yes (don't forget to update the JS-LIB team about the change)
  • No

@BalduinLandolt BalduinLandolt self-assigned this May 15, 2023
@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Patch coverage: 44.00% and project coverage change: -67.03 ⚠️

Comparison is base (7af1c27) 85.13% compared to head (d1e31f8) 18.11%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2666       +/-   ##
===========================================
- Coverage   85.13%   18.11%   -67.03%     
===========================================
  Files         277      277               
  Lines       28958    28947       -11     
===========================================
- Hits        24654     5243    -19411     
- Misses       4304    23704    +19400     
Impacted Files Coverage Δ
...la/org/knora/webapi/routing/v2/SearchRouteV2.scala 0.00% <0.00%> (-84.93%) ⬇️
...a/org/knora/webapi/util/ZScopedJavaIoStreams.scala 86.36% <ø> (+38.21%) ⬆️
...pi/messages/util/rdf/jenaimpl/JenaFormatUtil.scala 43.28% <50.00%> (-38.81%) ⬇️
...e/triplestore/api/TriplestoreServiceInMemory.scala 73.33% <100.00%> (+73.33%) ⬆️

... and 221 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@BalduinLandolt BalduinLandolt enabled auto-merge (squash) May 16, 2023 14:35
@BalduinLandolt BalduinLandolt merged commit 873eb46 into main May 16, 2023
12 checks passed
@BalduinLandolt BalduinLandolt deleted the wip/add-more-gravsearch-metrics branch May 16, 2023 15:05
mpro7 pushed a commit that referenced this pull request May 17, 2023
mpro7 pushed a commit that referenced this pull request May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants