feat: add export of assets (DEV-2106) #2668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces: * KnoraProjectRepoInMemory an inmemory implementation for tests * ProjectExportService the service which will be responsible for importing and exporting project data * RestPermissionService a service containing the logic for checking persmissions and turning them into a authorization exception Moves: * function projectDataNamedGraphV2 function from StringFormatter to ProjectADMService companion object
Introduces: * KnoraProjectRepoInMemory an in-memory implementation for tests * ProjectExportService the service which will be responsible for importing and exporting project data * RestPermissionService a service containing the logic for checking permissions and turning them into a authorization exception Moves: * function projectDataNamedGraphV2 function from StringFormatter to ProjectADMService companion object
…ombiner implementation based on ZIO The CombiningRdfProcessor assumed that the first exported graph contained all the prefixes for all graphs. The old combineGraph method did not properly close all io streams in case a rdfFormatUtil.parseWithStreamProcessor call would produce a failure.
BalduinLandolt
approved these changes
May 25, 2023
webapi/src/main/scala/org/knora/webapi/slice/admin/domain/service/ProjectExportService.scala
Show resolved
Hide resolved
webapi/src/main/scala/org/knora/webapi/slice/admin/domain/service/ProjectExportService.scala
Show resolved
Hide resolved
| val projectGraph = ProjectADMService.projectDataNamedGraphV2(project) | ||
| for { | ||
| ontologyGraphs <- ontologyRepo.findOntologyGraphsByProject(project) | ||
| query = findAllAssets(ontologyGraphs :+ InternalIri(KnoraBaseOntologyIri), projectGraph) |
There was a problem hiding this comment.
you add KnoraBase here, but no the other builtins (admin, standoff, etc.). Is this intentional or an oversight?
.../src/main/twirl/org/knora/webapi/messages/twirl/queries/sparql/admin/findAllAssets.scala.txt
Outdated
Show resolved
Hide resolved
.../src/main/twirl/org/knora/webapi/messages/twirl/queries/sparql/admin/findAllAssets.scala.txt
Outdated
Show resolved
Hide resolved
.../src/main/twirl/org/knora/webapi/messages/twirl/queries/sparql/admin/findAllAssets.scala.txt
Show resolved
Hide resolved
Co-authored-by: Balduin Landolt <33053745+BalduinLandolt@users.noreply.github.com>
…sparql/admin/findAllAssets.scala.txt Co-authored-by: Balduin Landolt <33053745+BalduinLandolt@users.noreply.github.com>
…sparql/admin/findAllAssets.scala.txt Co-authored-by: Balduin Landolt <33053745+BalduinLandolt@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Task Description/Number
Issue Number: DEV-2106
Basic Requirements
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR change client-test-data?