Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove unused GroupShortADM (NO-TICKET) #2674

Merged
merged 1 commit into from May 23, 2023

Conversation

seakayone
Copy link
Collaborator

@seakayone seakayone commented May 23, 2023

Pull Request Checklist

Task Description/Number

Issue Number: NO-TICKET

Basic Requirements

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • fix: represents bug fixes
  • refactor: represents production code refactoring
  • feat: represents a new feature
  • docs: documentation changes (no production code change)
  • chore: maintenance tasks (no production code change)
  • test: all about tests: adding, refactoring tests (no production code change)
  • other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No
  • Maybe (not 100% sure => check with FE)

Does this PR change client-test-data?

  • Yes (don't forget to update the JS-LIB team about the change)
  • No

@seakayone seakayone self-assigned this May 23, 2023
@seakayone seakayone marked this pull request as ready for review May 23, 2023 13:23
@seakayone seakayone enabled auto-merge (squash) May 23, 2023 13:23
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Patch coverage: 15.66% and project coverage change: -67.01 ⚠️

Comparison is base (7af1c27) 85.13% compared to head (2d907d7) 18.13%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2674       +/-   ##
===========================================
- Coverage   85.13%   18.13%   -67.01%     
===========================================
  Files         277      277               
  Lines       28958    28900       -58     
===========================================
- Hits        24654     5241    -19413     
- Misses       4304    23659    +19355     
Impacted Files Coverage Δ
.../org/knora/webapi/messages/OntologyConstants.scala 98.35% <0.00%> (-1.27%) ⬇️
...la/org/knora/webapi/messages/StringFormatter.scala 52.88% <0.00%> (-35.65%) ⬇️
...rmissionsmessages/PermissionsMessagesUtilADM.scala 70.45% <0.00%> (-29.55%) ⬇️
...a/webapi/messages/util/search/QueryTraverser.scala 1.29% <ø> (-91.01%) ⬇️
...nora/webapi/messages/util/search/SparqlQuery.scala 0.00% <ø> (-82.25%) ⬇️
...ravsearch/prequery/AbstractPrequeryGenerator.scala 0.00% <0.00%> (-85.72%) ⬇️
...search/prequery/InferenceOptimizationService.scala 3.12% <0.00%> (-84.76%) ⬇️
...gravsearch/transformers/ConstructTransformer.scala 6.66% <0.00%> (-63.34%) ⬇️
...h/gravsearch/transformers/OntologyInferencer.scala 2.50% <ø> (-91.25%) ⬇️
...ch/gravsearch/transformers/SelectTransformer.scala 0.00% <ø> (-85.72%) ⬇️
... and 11 more

... and 204 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@seakayone seakayone changed the title chore: Remove GroupShortADM (NO-TICKET) chore: Remove unused GroupShortADM (NO-TICKET) May 23, 2023
@seakayone seakayone merged commit 3676fbf into main May 23, 2023
12 checks passed
@seakayone seakayone deleted the chore/remove-unused-code branch May 23, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants