Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix Sipi get file response if dsp-api responds with Not Found during permission check (NO-TICKET) #2677

Merged
merged 14 commits into from May 25, 2023

Conversation

seakayone
Copy link
Collaborator

@seakayone seakayone commented May 24, 2023

Pull Request Checklist

Task Description/Number

Bugfix:

  • Given a 404 during Sipi's permission check for a file then Sipi should return Not Found

Other changes:

  • Add SipiIT tests for existing file and different permissions

Issue Number: NO-TICKET

Basic Requirements

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • fix: represents bug fixes
  • refactor: represents production code refactoring
  • feat: represents a new feature
  • docs: documentation changes (no production code change)
  • chore: maintenance tasks (no production code change)
  • test: all about tests: adding, refactoring tests (no production code change)
  • other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No
  • Maybe (not 100% sure => check with FE)

Does this PR change client-test-data?

  • Yes (don't forget to update the JS-LIB team about the change)
  • No

@seakayone seakayone self-assigned this May 24, 2023
@seakayone seakayone force-pushed the bugfix/fix-sipi-responses-2 branch from f28a837 to 34aa04e Compare May 24, 2023 16:32
@seakayone seakayone changed the title Add tests for existing file and different permissions test: Add tests for existing file and different permissions May 24, 2023
@seakayone seakayone marked this pull request as ready for review May 24, 2023 16:34
@seakayone seakayone changed the title test: Add tests for existing file and different permissions test: Add SipiIT tests for existing file and different permissions May 24, 2023
@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Patch coverage: 41.99% and project coverage change: -67.22 ⚠️

Comparison is base (7af1c27) 85.13% compared to head (52394be) 17.92%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2677       +/-   ##
===========================================
- Coverage   85.13%   17.92%   -67.22%     
===========================================
  Files         277      277               
  Lines       28958    28795      -163     
===========================================
- Hits        24654     5161    -19493     
- Misses       4304    23634    +19330     
Impacted Files Coverage Δ
.../org/knora/webapi/messages/OntologyConstants.scala 98.35% <0.00%> (-1.27%) ⬇️
...min/responder/listsmessages/ListsMessagesADM.scala 0.00% <0.00%> (-70.71%) ⬇️
...rmissionsmessages/PermissionsMessagesUtilADM.scala 70.45% <0.00%> (-29.55%) ⬇️
...knora/webapi/messages/util/PermissionUtilADM.scala 32.53% <0.00%> (-53.02%) ⬇️
...rg/knora/webapi/messages/util/rdf/JsonLDUtil.scala 38.73% <0.00%> (-38.07%) ⬇️
...a/webapi/messages/util/search/QueryTraverser.scala 1.29% <ø> (-91.01%) ⬇️
...nora/webapi/messages/util/search/SparqlQuery.scala 0.00% <ø> (-82.25%) ⬇️
...ravsearch/prequery/AbstractPrequeryGenerator.scala 0.00% <0.00%> (-85.72%) ⬇️
...search/prequery/InferenceOptimizationService.scala 3.12% <0.00%> (-84.76%) ⬇️
...gravsearch/transformers/ConstructTransformer.scala 6.66% <0.00%> (-63.34%) ⬇️
... and 44 more

... and 172 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@seakayone seakayone changed the title test: Add SipiIT tests for existing file and different permissions fix: Fix Sipi response if dsp-api responds with Not Found (NO-TICKET) May 25, 2023
@seakayone seakayone changed the title fix: Fix Sipi response if dsp-api responds with Not Found (NO-TICKET) fix: Fix Sipi get file response if dsp-api responds with Not Found during permission check (NO-TICKET) May 25, 2023
Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@seakayone seakayone enabled auto-merge (squash) May 25, 2023 07:15
@seakayone seakayone disabled auto-merge May 25, 2023 07:18
@seakayone seakayone enabled auto-merge (squash) May 25, 2023 07:18
@seakayone seakayone merged commit 4e1c6c2 into main May 25, 2023
13 checks passed
@seakayone seakayone deleted the bugfix/fix-sipi-responses-2 branch May 25, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants