New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix Sipi get file response if dsp-api responds with Not Found during permission check (NO-TICKET) #2677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seakayone
force-pushed
the
bugfix/fix-sipi-responses-2
branch
from
May 24, 2023 16:32
f28a837
to
34aa04e
Compare
seakayone
changed the title
Add tests for existing file and different permissions
test: Add tests for existing file and different permissions
May 24, 2023
seakayone
changed the title
test: Add tests for existing file and different permissions
test: Add SipiIT tests for existing file and different permissions
May 24, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2677 +/- ##
===========================================
- Coverage 85.13% 17.92% -67.22%
===========================================
Files 277 277
Lines 28958 28795 -163
===========================================
- Hits 24654 5161 -19493
- Misses 4304 23634 +19330
☔ View full report in Codecov by Sentry. |
seakayone
changed the title
test: Add SipiIT tests for existing file and different permissions
fix: Fix Sipi response if dsp-api responds with Not Found (NO-TICKET)
May 25, 2023
seakayone
changed the title
fix: Fix Sipi response if dsp-api responds with Not Found (NO-TICKET)
fix: Fix Sipi get file response if dsp-api responds with Not Found during permission check (NO-TICKET)
May 25, 2023
BalduinLandolt
approved these changes
May 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Task Description/Number
Bugfix:
Other changes:
Issue Number: NO-TICKET
Basic Requirements
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR change client-test-data?