Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add more tests for Sipi responses (NO-TICKET) #2679

Merged
merged 7 commits into from May 25, 2023

Conversation

seakayone
Copy link
Collaborator

@seakayone seakayone commented May 25, 2023

Pull Request Checklist

Task Description/Number

  • Add more tests for iiif endpoint
  • Refactor SipiIT to split suites by endpoints

Issue Number: NO-TICKET

Basic Requirements

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • fix: represents bug fixes
  • refactor: represents production code refactoring
  • feat: represents a new feature
  • docs: documentation changes (no production code change)
  • chore: maintenance tasks (no production code change)
  • test: all about tests: adding, refactoring tests (no production code change)
  • other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No
  • Maybe (not 100% sure => check with FE)

Does this PR change client-test-data?

  • Yes (don't forget to update the JS-LIB team about the change)
  • No

@seakayone seakayone self-assigned this May 25, 2023
@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Patch coverage: 96.08% and project coverage change: +2.17 🎉

Comparison is base (7af1c27) 85.13% compared to head (cd160cf) 87.31%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2679      +/-   ##
==========================================
+ Coverage   85.13%   87.31%   +2.17%     
==========================================
  Files         277      277              
  Lines       28958    28795     -163     
==========================================
+ Hits        24654    25141     +487     
+ Misses       4304     3654     -650     
Impacted Files Coverage Δ
...a/webapi/messages/util/search/QueryTraverser.scala 92.20% <ø> (-0.10%) ⬇️
...nora/webapi/messages/util/search/SparqlQuery.scala 83.01% <ø> (+0.77%) ⬆️
...h/gravsearch/transformers/OntologyInferencer.scala 92.50% <ø> (-1.25%) ⬇️
...ch/gravsearch/transformers/SelectTransformer.scala 83.33% <ø> (-2.39%) ⬇️
...rch/gravsearch/transformers/WhereTransformer.scala 100.00% <ø> (ø)
...api/messages/util/standoff/StandoffTagUtilV2.scala 85.78% <ø> (ø)
...ra/webapi/responders/admin/ListsResponderADM.scala 86.94% <0.00%> (ø)
...knora/webapi/responders/v1/SearchResponderV1.scala 90.85% <ø> (ø)
...ora/webapi/responders/v2/StandoffResponderV2.scala 88.64% <ø> (ø)
...api/routing/admin/lists/GetListItemsRouteADM.scala 100.00% <ø> (ø)
... and 44 more

... and 32 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@seakayone seakayone marked this pull request as ready for review May 25, 2023 11:29
@seakayone seakayone enabled auto-merge (squash) May 25, 2023 11:41
requestPattern: RequestPatternBuilder
): Boolean =
Try(server.verify(amount, requestPattern)) match {
case Failure(e: Throwable) => println(s"\nMockDspApiServer: ${e.getMessage}"); false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be logged instead of printed or is this println something you forgot to remove?

@seakayone seakayone merged commit 74f49ca into main May 25, 2023
13 checks passed
@seakayone seakayone deleted the bugfix/fix-sipi-responses branch May 25, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants