New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add more tests for Sipi responses (NO-TICKET) #2679
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2679 +/- ##
==========================================
+ Coverage 85.13% 87.31% +2.17%
==========================================
Files 277 277
Lines 28958 28795 -163
==========================================
+ Hits 24654 25141 +487
+ Misses 4304 3654 -650
☔ View full report in Codecov by Sentry. |
4c00f1c
to
c27858b
Compare
requestPattern: RequestPatternBuilder | ||
): Boolean = | ||
Try(server.verify(amount, requestPattern)) match { | ||
case Failure(e: Throwable) => println(s"\nMockDspApiServer: ${e.getMessage}"); false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't it be logged instead of printed or is this println
something you forgot to remove?
Pull Request Checklist
Task Description/Number
SipiIT
to split suites by endpointsIssue Number: NO-TICKET
Basic Requirements
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR change client-test-data?