Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add import of trig file of export (DEV-2249) #2680

Merged
merged 20 commits into from Jun 8, 2023

Conversation

seakayone
Copy link
Collaborator

@seakayone seakayone commented May 26, 2023

Pull Request Checklist

Task Description/Number

Issue Number: DEV-2249

New features:

  • add import endpoint
    • POST on import endpoint will import the trig file from a formerly exported project
  • add list exports enpdoint
    • GET on list endpoint will return all present exports

Other changes:

  • Extract export related storage functionality into ProjectExportStorageService
  • Make FusekiTestContainer extend GenericTestContainer so that testcontainers functionality can be easier accessed in tests
  • Remove unused AppConfig from dsp package
  • Add unzip to ZipUtility
  • Use shortcode to identify project in all exports/imports
  • Run integration tests with sbt directly without prior packaging into a jar

Basic Requirements

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • fix: represents bug fixes
  • refactor: represents production code refactoring
  • feat: represents a new feature
  • docs: documentation changes (no production code change)
  • chore: maintenance tasks (no production code change)
  • test: all about tests: adding, refactoring tests (no production code change)
  • other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No
  • Maybe (not 100% sure => check with FE)

Does this PR change client-test-data?

  • Yes (don't forget to update the JS-LIB team about the change)
  • No

@seakayone seakayone self-assigned this May 26, 2023
@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Patch coverage: 35.32% and project coverage change: -8.35 ⚠️

Comparison is base (ee3cddc) 17.89% compared to head (bbd968e) 9.55%.

Additional details and impacted files
@@            Coverage Diff            @@
##             main   #2680      +/-   ##
=========================================
- Coverage   17.89%   9.55%   -8.35%     
=========================================
  Files         277     279       +2     
  Lines       28855   28936      +81     
=========================================
- Hits         5165    2766    -2399     
- Misses      23690   26170    +2480     
Impacted Files Coverage Δ
...la/org/knora/webapi/messages/StringFormatter.scala 50.87% <0.00%> (-1.08%) ⬇️
...webapi/messages/util/ConstructResponseUtilV2.scala 0.00% <0.00%> (-0.96%) ⬇️
...api/messages/util/standoff/StandoffTagUtilV2.scala 0.00% <0.00%> (-0.16%) ⬇️
...api/messages/util/standoff/XMLToStandoffUtil.scala 0.00% <0.00%> (ø)
...esponder/resourcemessages/ResourceMessagesV2.scala 0.00% <0.00%> (ø)
...esponder/standoffmessages/StandoffMessagesV2.scala 0.00% <0.00%> (-9.66%) ⬇️
...s/v2/responder/valuemessages/ValueMessagesV2.scala 0.00% <0.00%> (ø)
...scala/org/knora/webapi/responders/IriService.scala 0.00% <0.00%> (-65.39%) ⬇️
...knora/webapi/responders/v1/ValuesResponderV1.scala 0.00% <ø> (-1.13%) ⬇️
...ra/webapi/responders/v2/ResourcesResponderV2.scala 0.00% <ø> (-1.27%) ⬇️
... and 21 more

... and 82 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

In order to be able to find the files as class path resources sbt either has to package them into the jar which was packaged or not package the jar at all.
Use the latter method as it is more simple.
@seakayone seakayone changed the title Feat/add import of export feat: add import of trig file of export (DEV-2249) Jun 7, 2023
@linear
Copy link

linear bot commented Jun 7, 2023

@seakayone seakayone marked this pull request as ready for review June 7, 2023 08:39
Copy link
Collaborator

@mpro7 mpro7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks good. Check my minor stylistic finds:

Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seakayone seakayone enabled auto-merge (squash) June 8, 2023 09:56
@seakayone seakayone merged commit 6fb0e8c into main Jun 8, 2023
12 of 13 checks passed
@seakayone seakayone deleted the feat/add-import-of-export branch June 8, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants