New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add import of trig file of export (DEV-2249) #2680
Conversation
7d4315f
to
d63b889
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2680 +/- ##
=========================================
- Coverage 17.89% 9.55% -8.35%
=========================================
Files 277 279 +2
Lines 28855 28936 +81
=========================================
- Hits 5165 2766 -2399
- Misses 23690 26170 +2480
☔ View full report in Codecov by Sentry. |
d63b889
to
4914f4a
Compare
6384b47
to
ca781b4
Compare
In order to be able to find the files as class path resources sbt either has to package them into the jar which was packaged or not package the jar at all. Use the latter method as it is more simple.
cb884e1
to
24378ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, looks good. Check my minor stylistic finds:
webapi/src/main/scala/org/knora/webapi/http/handler/ExceptionHandlerZ.scala
Show resolved
Hide resolved
webapi/src/main/scala/org/knora/webapi/http/handler/ExceptionHandlerZ.scala
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pull Request Checklist
Task Description/Number
Issue Number: DEV-2249
New features:
Other changes:
ProjectExportStorageService
FusekiTestContainer
extendGenericTestContainer
so that testcontainers functionality can be easier accessed in testsAppConfig
fromdsp
packageunzip
toZipUtility
shortcode
to identify project in all exports/importsBasic Requirements
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR change client-test-data?