Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Dsp-ingest integration for import/export of projects DEV-2297 #2722

Merged
merged 11 commits into from Jun 30, 2023

Conversation

seakayone
Copy link
Collaborator

@seakayone seakayone commented Jun 29, 2023

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

Basic Requirements

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • fix: represents bug fixes
  • refactor: represents production code refactoring
  • feat: represents a new feature
  • docs: documentation changes (no production code change)
  • chore: maintenance tasks (no production code change)
  • test: all about tests: adding, refactoring tests (no production code change)
  • other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No
  • Maybe (not 100% sure => check with FE)

Does this PR change client-test-data?

  • Yes (don't forget to update the JS-LIB team about the change)
  • No

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Patch coverage: 23.45% and project coverage change: +8.44 🎉

Comparison is base (e3a19dd) 9.55% compared to head (8e13a0e) 18.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            main    #2722      +/-   ##
=========================================
+ Coverage   9.55%   18.00%   +8.44%     
=========================================
  Files        279      281       +2     
  Lines      28936    28899      -37     
=========================================
+ Hits        2766     5202    +2436     
+ Misses     26170    23697    -2473     
Impacted Files Coverage Δ
webapi/src/main/scala/org/knora/webapi/Main.scala 0.00% <ø> (ø)
...rg/knora/webapi/routing/admin/ProjectsRouteZ.scala 91.42% <0.00%> (+0.77%) ⬆️
...ice/admin/api/service/ProjectsADMRestService.scala 60.00% <0.00%> (+11.42%) ⬆️
...webapi/slice/admin/domain/model/KnoraProject.scala 0.00% <0.00%> (ø)
...i/slice/admin/domain/service/DspIngestClient.scala 4.76% <4.76%> (ø)
...tore/triplestore/impl/TriplestoreServiceLive.scala 61.44% <9.09%> (+61.44%) ⬆️
...ce/admin/domain/service/ProjectImportService.scala 12.24% <14.28%> (-4.12%) ⬇️
...scala/org/knora/webapi/routing/Authenticator.scala 8.84% <16.66%> (+8.84%) ⬆️
...ce/admin/domain/service/ProjectExportService.scala 68.18% <16.66%> (+68.18%) ⬆️
...main/scala/org/knora/webapi/config/AppConfig.scala 86.84% <90.90%> (+1.12%) ⬆️
... and 1 more

... and 104 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@seakayone seakayone marked this pull request as ready for review June 30, 2023 08:14
@seakayone seakayone changed the title Dsp ingest integration feat: Dsp-ingest integration for import/export of projects DEV-2297 Jun 30, 2023
@linear
Copy link

linear bot commented Jun 30, 2023

Copy link
Collaborator

@mpro7 mpro7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One question below.

@seakayone seakayone enabled auto-merge (squash) June 30, 2023 09:51
@seakayone seakayone merged commit 12402f3 into main Jun 30, 2023
13 checks passed
@seakayone seakayone deleted the dsp-ingest-integration branch June 30, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants